mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-13 12:31:51 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Add user activation for pointerdown/up

Browse source 
Fixed FIXME's for pointerdown and pointerup events.
This commit is contained in:
Simon Farre 2025-04-13 16:20:31 +02:00 • committed by Andrew Kaster
parent a821fc03be
commit 87f6a11e47
Notes: github-actions[bot] 2025-04-13 16:37:42 +00:00
1 changed files with 13 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

15
Libraries/LibWeb/DOM/EventTarget.cpp
View file

@ -3,6 +3,7 @@
* Copyright (c) 2022, Luke Wilde <lukew@serenityos.org> * Copyright (c) 2022, Luke Wilde <lukew@serenityos.org>
* Copyright (c) 2024, Glenn Skrzypczak <glenn.skrzypczak@gmail.com> * Copyright (c) 2024, Glenn Skrzypczak <glenn.skrzypczak@gmail.com>
* Copyright (c) 2025, Felipe Muñoz Mazur <felipe.munoz.mazur@protonmail.com> * Copyright (c) 2025, Felipe Muñoz Mazur <felipe.munoz.mazur@protonmail.com>
* Copyright (c) 2025, Simon Farre <simon.farre.cx@gmail.com>
* *
* SPDX-License-Identifier: BSD-2-Clause * SPDX-License-Identifier: BSD-2-Clause
*/ */
@ -39,6 +40,7 @@
#include <LibWeb/UIEvents/EventNames.h> #include <LibWeb/UIEvents/EventNames.h>
#include <LibWeb/UIEvents/KeyCode.h> #include <LibWeb/UIEvents/KeyCode.h>
#include <LibWeb/UIEvents/KeyboardEvent.h> #include <LibWeb/UIEvents/KeyboardEvent.h>
#include <LibWeb/UIEvents/PointerEvent.h>
#include <LibWeb/WebIDL/AbstractOperations.h> #include <LibWeb/WebIDL/AbstractOperations.h>
namespace Web::DOM { namespace Web::DOM {
@ -822,10 +824,19 @@ bool EventTarget::dispatch_event(Event& event)
if (event.type() == UIEvents::EventNames::mousedown) if (event.type() == UIEvents::EventNames::mousedown)
return true; return true;
// FIXME:
// pointerdown, provided the event's pointerType is "mouse". // pointerdown, provided the event's pointerType is "mouse".
if (event.type() == UIEvents::EventNames::pointerdown) {
if (auto* pointer_event = as_if<UIEvents::PointerEvent>(&event))
return pointer_event->pointer_type() == "mouse"sv;
}
// pointerup, provided the event's pointerType is not "mouse". // pointerup, provided the event's pointerType is not "mouse".
// touchend. if (event.type() == UIEvents::EventNames::pointerup) {
if (auto* pointer_event = as_if<UIEvents::PointerEvent>(&event))
return pointer_event->pointer_type() != "mouse"sv;
}
// FIXME: touchend
return false; return false;
}; };