mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-07 00:29:15 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Add methods to Window that must do nothing

Browse source 
This change adds the `captureEvents()` and `releaseEvents()` methods to
the window object. These methods are obsolete, but are still included
in the HTML specification, which says they must do nothing.
This commit is contained in:
Tim Ledbetter 2024-04-14 07:38:10 +01:00 • committed by Andreas Kling
commit 88f3145f8a
Notes: sideshowbarker 2024-07-17 02:38:39 +09:00
5 changed files with 28 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Tests/LibWeb/Text/expected/DOM/Window-methods-that-must-do-nothing.txt Normal file
View file

@ -0,0 +1,2 @@
window.captureEvents() returns undefined: true
window.releaseEvents() returns undefined: true

8
Tests/LibWeb/Text/input/DOM/Window-methods-that-must-do-nothing.html Normal file
View file

@ -0,0 +1,8 @@
<!DOCTYPE html>
<script src="../include.js"></script>
<script>
test(() => {
println(`window.captureEvents() returns undefined: ${window.captureEvents() === undefined}`);
println(`window.releaseEvents() returns undefined: ${window.releaseEvents() === undefined}`);
});
</script>

12
Userland/Libraries/LibWeb/HTML/Window.cpp
View file

@ -1600,6 +1600,18 @@ JS::NonnullGCPtr<Crypto::Crypto> Window::crypto()
return JS::NonnullGCPtr { *m_crypto };
}
// https://html.spec.whatwg.org/multipage/obsolete.html#dom-window-captureevents
void Window::capture_events()
{
// Do nothing.
}
// https://html.spec.whatwg.org/multipage/obsolete.html#dom-document-releaseevents
void Window::release_events()
{
// Do nothing.
}
// https://html.spec.whatwg.org/multipage/nav-history-apis.html#dom-navigation
JS::NonnullGCPtr<Navigation> Window::navigation()
{

3
Userland/Libraries/LibWeb/HTML/Window.h
View file

@ -202,6 +202,9 @@ public:
[[nodiscard]] JS::NonnullGCPtr<Crypto::Crypto> crypto();
void capture_events();
void release_events();
[[nodiscard]] JS::NonnullGCPtr<CustomElementRegistry> custom_elements();
HighResolutionTime::DOMHighResTimeStamp get_last_activation_timestamp() const { return m_last_activation_timestamp; }

3
Userland/Libraries/LibWeb/HTML/Window.idl
View file

@ -110,6 +110,9 @@ interface Window : EventTarget {
// https://w3c.github.io/webcrypto/#crypto-interface
[SameObject] readonly attribute Crypto crypto;
undefined captureEvents();
undefined releaseEvents();
};
Window includes AnimationFrameProvider;
Window includes GlobalEventHandlers;