mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-09-18 15:32:22 +00:00
LibWeb: Make BrowsingContex::page() return a Page&
This exposed a whole slew of now-unnecessary null checks. :^) Co-Authored-By: Andreas Kling <kling@serenityos.org>
This commit is contained in:
parent
af2bcc3b56
commit
88f8ea7c60
Notes:
sideshowbarker
2024-07-17 02:38:39 +09:00
Author: https://github.com/shannonbooth
Commit: 88f8ea7c60
Pull-request: https://github.com/SerenityOS/serenity/pull/22142
Issue: https://github.com/SerenityOS/serenity/issues/22091
9 changed files with 56 additions and 88 deletions
|
@ -130,8 +130,7 @@ static JS::NonnullGCPtr<HTML::BrowsingContext> obtain_a_browsing_context_to_use_
|
|||
}
|
||||
|
||||
// 3. Let newBrowsingContext be the first return value of creating a new top-level browsing context and document
|
||||
VERIFY(browsing_context.page());
|
||||
auto new_browsing_context = HTML::create_a_new_top_level_browsing_context_and_document(*browsing_context.page()).release_value_but_fixme_should_propagate_errors().browsing_context;
|
||||
auto new_browsing_context = HTML::create_a_new_top_level_browsing_context_and_document(browsing_context.page()).release_value_but_fixme_should_propagate_errors().browsing_context;
|
||||
|
||||
// FIXME: 4. If navigationCOOP's value is "same-origin-plurs-COEP", then set newBrowsingContext's group's
|
||||
// cross-origin isolation mode to either "logical" or "concrete". The choice of which is implementation-defined.
|
||||
|
@ -1910,12 +1909,12 @@ void Document::update_readiness(HTML::DocumentReadyState readiness_value)
|
|||
|
||||
Page* Document::page()
|
||||
{
|
||||
return m_browsing_context ? m_browsing_context->page() : nullptr;
|
||||
return m_browsing_context ? &m_browsing_context->page() : nullptr;
|
||||
}
|
||||
|
||||
Page const* Document::page() const
|
||||
{
|
||||
return m_browsing_context ? m_browsing_context->page() : nullptr;
|
||||
return m_browsing_context ? &m_browsing_context->page() : nullptr;
|
||||
}
|
||||
|
||||
EventTarget* Document::get_parent(Event const& event)
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue