mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-09-10 11:36:22 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Abort ongoing navigation before firing next navigation event

Browse source 
I haven't found this being mentioned in the current spec, but that is
what chromium (atm the only other Navigation API implementer) does.

Fixes crashing when location.hash is changed subsequently more than once
using JS.
This commit is contained in:
Aliaksandr Kalenik 2024-04-16 18:29:07 +02:00 • committed by Andreas Kling
commit 890da021c4
Notes: sideshowbarker 2024-07-17 02:59:43 +09:00
3 changed files with 16 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Tests/LibWeb/Text/expected/navigation/trigger-fragment-navigation-from-js.txt Normal file
View file

@ -0,0 +1,2 @@
#1
#2

10
Tests/LibWeb/Text/input/navigation/trigger-fragment-navigation-from-js.html Normal file
View file

@ -0,0 +1,10 @@
<!DOCTYPE html>
<script src="../include.js"></script>
<script>
test(() => {
location.hash = "#1";
println(location.hash);
location.hash = "#2";
println(location.hash);
});
</script>

4
Userland/Libraries/LibWeb/HTML/Navigation.cpp
View file

@ -918,6 +918,10 @@ bool Navigation::inner_navigate_event_firing_algorithm(
Optional<String> download_request_filename,
Optional<SerializationRecord> classic_history_api_state)
{
// NOTE: Specification assumes that ongoing navigation event is cancelled before dispatching next navigation event.
if (m_ongoing_navigate_event)
abort_the_ongoing_navigation();
auto& realm = relevant_realm(*this);
// 1. If navigation has entries and events disabled, then: