mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-31 06:38:22 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb/CSS: Introduce CSSNumericValue and CSSUnitValue type stubs

Browse source 
CSS-Typed-OM has the following hierarchy:

CSSStyleValue
- CSSNumericValue
  - CSSUnitValue
  - CSSMathValue
    - ...various math functions...

Somewhat unintuitively, numbers are also stored using CSSUnitValue with
`unit = "number"`.

There are no distinct classes for LengthStyleValue, etc in the spec, but
they're convenient for us, so they are implemented as subclasses of
CSSUnitValue, at least for now.
This commit is contained in:
Sam Atkins 2024-08-14 16:25:48 +01:00 • committed by Sam Atkins
commit 8952764267
Notes: github-actions[bot] 2024-08-21 09:53:21 +00:00
20 changed files with 225 additions and 107 deletions
Download patch file Download diff file Expand all files Collapse all files

18
Userland/Libraries/LibWeb/CSS/StyleValues/NumberStyleValue.h
View file

@ -1,7 +1,7 @@
/*
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2021, Tobias Christiansen <tobyase@serenityos.org>
* Copyright (c) 2021-2023, Sam Atkins <atkinssj@serenityos.org>
* Copyright (c) 2021-2024, Sam Atkins <sam@ladybird.org>
* Copyright (c) 2022-2023, MacDue <macdue@dueutil.tech>
*
* SPDX-License-Identifier: BSD-2-Clause
@ -9,11 +9,11 @@
#pragma once
#include <LibWeb/CSS/CSSStyleValue.h>
#include <LibWeb/CSS/StyleValues/CSSUnitValue.h>
namespace Web::CSS {
class NumberStyleValue : public StyleValueWithDefaultOperators<NumberStyleValue> {
class NumberStyleValue final : public CSSUnitValue {
public:
static ValueComparingNonnullRefPtr<NumberStyleValue> create(double value)
{
@ -21,14 +21,22 @@ public:
}
double number() const { return m_value; }
virtual double value() const override { return m_value; }
virtual StringView unit() const override { return "number"sv; }
virtual String to_string() const override;
bool properties_equal(NumberStyleValue const& other) const { return m_value == other.m_value; }
bool equals(CSSStyleValue const& other) const override
{
if (type() != other.type())
return false;
auto const& other_number = other.as_number();
return m_value == other_number.m_value;
}
private:
explicit NumberStyleValue(double value)
: StyleValueWithDefaultOperators(Type::Number)
: CSSUnitValue(Type::Number)
, m_value(value)
{
}