mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-21 18:00:16 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Use NonnullGCPtr for HTMLCollection::collect_matching_elements

Browse source 
The pointers here can never be null, so lets engrain that into the type
for clarity.
This commit is contained in:
Shannon Booth 2024-03-31 21:55:43 +02:00 • committed by Andreas Kling
commit 897f55ca8a
Notes: sideshowbarker 2024-07-17 02:59:43 +09:00
2 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibWeb/DOM/HTMLCollection.cpp
View file

@ -50,7 +50,7 @@ void HTMLCollection::visit_edges(Cell::Visitor& visitor)
visitor.visit(element);
}
JS::MarkedVector<Element*> HTMLCollection::collect_matching_elements() const
JS::MarkedVector<JS::NonnullGCPtr<Element>> HTMLCollection::collect_matching_elements() const
{
if (m_cached_dom_tree_version != root()->document().dom_tree_version()) {
m_cached_elements.clear();
@ -70,7 +70,7 @@ JS::MarkedVector<Element*> HTMLCollection::collect_matching_elements() const
m_cached_dom_tree_version = root()->document().dom_tree_version();
}
JS::MarkedVector<Element*> elements(heap());
JS::MarkedVector<JS::NonnullGCPtr<Element>> elements(heap());
for (auto& element : m_cached_elements)
elements.append(element);
return elements;

2
Userland/Libraries/LibWeb/DOM/HTMLCollection.h
View file

@ -38,7 +38,7 @@ public:
Element* item(size_t index) const;
Element* named_item(FlyString const& name) const;
JS::MarkedVector<Element*> collect_matching_elements() const;
JS::MarkedVector<JS::NonnullGCPtr<Element>> collect_matching_elements() const;
virtual WebIDL::ExceptionOr<JS::Value> item_value(size_t index) const override;
virtual WebIDL::ExceptionOr<JS::Value> named_item_value(FlyString const& name) const override;