mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-19 15:32:31 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Update CSSRule parent style sheet whenever parent rule changes

Browse source
This commit is contained in:
Callum Law 2025-06-24 00:42:19 +12:00 • committed by Sam Atkins
parent f336667771
commit 89a08cb7cf
Notes: github-actions[bot] 2025-06-23 14:22:43 +00:00
4 changed files with 27 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Libraries/LibWeb/CSS/CSSRule.cpp
View file

@ -53,6 +53,11 @@ void CSSRule::set_css_text(StringView)
void CSSRule::set_parent_rule(CSSRule* parent_rule) void CSSRule::set_parent_rule(CSSRule* parent_rule)
{ {
m_parent_rule = parent_rule; m_parent_rule = parent_rule;
if (parent_rule == nullptr)
set_parent_style_sheet(nullptr);
else
set_parent_style_sheet(parent_rule->parent_style_sheet());
clear_caches(); clear_caches();
} }

2
Libraries/LibWeb/CSS/CSSRuleList.cpp
View file

@ -171,8 +171,8 @@ WebIDL::ExceptionOr<void> CSSRuleList::remove_a_css_rule(u32 index)
m_rules.remove(index); m_rules.remove(index);
// 6. Set old rule’s parent CSS rule and parent CSS style sheet to null. // 6. Set old rule’s parent CSS rule and parent CSS style sheet to null.
// NOTE: We set the parent stylesheet to null within set_parent_rule.
old_rule.set_parent_rule(nullptr); old_rule.set_parent_rule(nullptr);
old_rule.set_parent_style_sheet(nullptr);
if (on_change) if (on_change)
on_change(); on_change();

1
Tests/LibWeb/Text/expected/css/group-inserted-rule-stylesheet-parent.txt Normal file
View file

@ -0,0 +1 @@
Pass!

20
Tests/LibWeb/Text/input/css/group-inserted-rule-stylesheet-parent.html Normal file
View file

@ -0,0 +1,20 @@
<!DOCTYPE html>
<html>
<style id="style">
@media all {
}
</style>
<script src="../include.js"></script>
<script>
test(() => {
const mediaRule = document.styleSheets[0].cssRules[0];
mediaRule.insertRule("foobar {}", 0);
if (mediaRule.cssRules[0].parentStyleSheet === document.styleSheets[0]) {
println("Pass!");
} else {
println("Fail!");
}
});
</script>
</html>