mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-09-03 08:08:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

Browser: Stop leaking popup windows

Browse source 
We were leaking the "view source" and "downloading file" windows for
some reason, presumably it was necessary when these were first added.
Since they are owned by the spawning browser window, there's no need
to leak them.
This commit is contained in:
Andreas Kling 2021-05-21 15:21:51 +02:00
commit 8a3e622538
Notes: sideshowbarker 2024-07-18 17:37:48 +09:00
1 changed files with 0 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Applications/Browser/Tab.cpp
View file

@ -61,7 +61,6 @@ void Tab::start_download(const URL& url)
window->set_resizable(false);
window->set_main_widget<DownloadWidget>(url);
window->show();
[[maybe_unused]] auto& unused = window.leak_ref();
}
void Tab::view_source(const URL& url, const String& source)
@ -76,7 +75,6 @@ void Tab::view_source(const URL& url, const String& source)
window->set_title(url.to_string());
window->set_icon(Gfx::Bitmap::load_from_file("/res/icons/16x16/filetype-text.png"));
window->show();
[[maybe_unused]] auto& unused = window.leak_ref();
}
Tab::Tab(BrowserWindow& window, Type type)