mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-02 14:19:48 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Unapply CSS filters after applying them to SVG

Browse source
This commit is contained in:
Psychpsyo 2024-11-23 22:08:36 +01:00 • committed by Tim Ledbetter
commit 8aaa9324b2
Notes: github-actions[bot] 2024-11-23 21:40:47 +00:00
3 changed files with 14 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Libraries/LibWeb/Painting/SVGSVGPaintable.cpp
View file

@ -59,8 +59,9 @@ void SVGSVGPaintable::paint_descendants(PaintContext& context, PaintableBox cons
auto paint_svg_box = [&](auto& svg_box) { auto paint_svg_box = [&](auto& svg_box) {
auto const& computed_values = svg_box.computed_values(); auto const& computed_values = svg_box.computed_values();
auto filters = paintable.computed_values().filter();
auto masking_area = svg_box.get_masking_area(); auto masking_area = svg_box.get_masking_area();
auto needs_to_save_state = computed_values.opacity() < 1 || svg_box.has_css_transform() || svg_box.get_masking_area().has_value(); auto needs_to_save_state = computed_values.opacity() < 1 || svg_box.has_css_transform() || svg_box.get_masking_area().has_value() || !filters.is_none();
if (needs_to_save_state) { if (needs_to_save_state) {
context.display_list_recorder().save(); context.display_list_recorder().save();
@ -70,7 +71,7 @@ void SVGSVGPaintable::paint_descendants(PaintContext& context, PaintableBox cons
context.display_list_recorder().apply_opacity(computed_values.opacity()); context.display_list_recorder().apply_opacity(computed_values.opacity());
} }
context.display_list_recorder().apply_filters(paintable.computed_values().filter()); context.display_list_recorder().apply_filters(filters);
if (svg_box.has_css_transform()) { if (svg_box.has_css_transform()) {
auto transform_matrix = svg_box.transform(); auto transform_matrix = svg_box.transform();

5
Tests/LibWeb/Ref/expected/svg-restore-after-filter.html Normal file
View file

@ -0,0 +1,5 @@
<!DOCTYPE html>
<svg width="10" height="10">
<rect width="10" height="10" fill="white"/>
</svg>
<span>This should be visible.</span>

6
Tests/LibWeb/Ref/input/svg-restore-after-filter.html Normal file
View file

@ -0,0 +1,6 @@
<!DOCTYPE html>
<link rel="match" href="../expected/svg-restore-after-filter.html">
<svg style="filter: opacity(0)" width="10" height="10">
<rect width="10" height="10"/>
</svg>
<span>This should be visible.</span>