mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-31 13:19:05 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb/HTML: Adjust some comments in Location implementation

Browse source 
To closer resemble the style of other places in the code base.
This commit is contained in:
Shannon Booth 2025-04-22 13:49:35 +12:00 • committed by Tim Ledbetter
commit 8ba6c7330d
Notes: github-actions[bot] 2025-04-23 07:25:46 +00:00
1 changed files with 7 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

16
Libraries/LibWeb/HTML/Location.cpp
View file

@ -47,11 +47,11 @@ void Location::initialize(JS::Realm& realm)
auto& vm = this->vm(); auto& vm = this->vm();
// Step 2: Let valueOf be location's relevant realm.[[Intrinsics]].[[%Object.prototype.valueOf%]]. // 2. Let valueOf be location's relevant realm.[[Intrinsics]].[[%Object.prototype.valueOf%]].
auto& intrinsics = realm.intrinsics(); auto& intrinsics = realm.intrinsics();
auto value_of_function = intrinsics.object_prototype()->get_without_side_effects(vm.names.valueOf); auto value_of_function = intrinsics.object_prototype()->get_without_side_effects(vm.names.valueOf);
// Step 3: Perform ! location.[[DefineOwnProperty]]("valueOf", { [[Value]]: valueOf, [[Writable]]: false, [[Enumerable]]: false, [[Configurable]]: false }). // 3. Perform ! location.[[DefineOwnProperty]]("valueOf", { [[Value]]: valueOf, [[Writable]]: false, [[Enumerable]]: false, [[Configurable]]: false }).
auto value_of_property_descriptor = JS::PropertyDescriptor { auto value_of_property_descriptor = JS::PropertyDescriptor {
.value = value_of_function, .value = value_of_function,
.writable = false, .writable = false,
@ -60,7 +60,7 @@ void Location::initialize(JS::Realm& realm)
}; };
MUST(internal_define_own_property(vm.names.valueOf, value_of_property_descriptor)); MUST(internal_define_own_property(vm.names.valueOf, value_of_property_descriptor));
// Step 4: Perform ! location.[[DefineOwnProperty]](%Symbol.toPrimitive%, { [[Value]]: undefined, [[Writable]]: false, [[Enumerable]]: false, [[Configurable]]: false }). // 4. Perform ! location.[[DefineOwnProperty]](%Symbol.toPrimitive%, { [[Value]]: undefined, [[Writable]]: false, [[Enumerable]]: false, [[Configurable]]: false }).
auto to_primitive_property_descriptor = JS::PropertyDescriptor { auto to_primitive_property_descriptor = JS::PropertyDescriptor {
.value = JS::js_undefined(), .value = JS::js_undefined(),
.writable = false, .writable = false,
@ -350,14 +350,14 @@ WebIDL::ExceptionOr<void> Location::set_search(String const& value)
} }
// 5. Otherwise, run these substeps: // 5. Otherwise, run these substeps:
else { else {
// 5.1. Let input be the given value with a single leading "?" removed, if any. // 1. Let input be the given value with a single leading "?" removed, if any.
auto value_as_string_view = value.bytes_as_string_view(); auto value_as_string_view = value.bytes_as_string_view();
auto input = value_as_string_view.substring_view(value_as_string_view.starts_with('?')); auto input = value_as_string_view.substring_view(value_as_string_view.starts_with('?'));
// 5.2. Set copyURL's query to the empty string. // 2. Set copyURL's query to the empty string.
copy_url.set_query(String {}); copy_url.set_query(String {});
// 5.3. Basic URL parse input, with null, the relevant Document's document's character encoding, copyURL as url, and query state as state override. // 3. Basic URL parse input, with null, the relevant Document's document's character encoding, copyURL as url, and query state as state override.
(void)URL::Parser::basic_parse(input, {}, &copy_url, URL::Parser::State::Query); (void)URL::Parser::basic_parse(input, {}, &copy_url, URL::Parser::State::Query);
} }
@ -390,10 +390,8 @@ WebIDL::ExceptionOr<String> Location::hash() const
// https://html.spec.whatwg.org/multipage/nav-history-apis.html#dom-location-hash // https://html.spec.whatwg.org/multipage/nav-history-apis.html#dom-location-hash
WebIDL::ExceptionOr<void> Location::set_hash(String const& value) WebIDL::ExceptionOr<void> Location::set_hash(String const& value)
{ {
// The hash setter steps are:
auto const relevant_document = this->relevant_document();
// 1. If this's relevant Document is null, then return. // 1. If this's relevant Document is null, then return.
auto const relevant_document = this->relevant_document();
if (!relevant_document) if (!relevant_document)
return {}; return {};