mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-05-03 17:58:49 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb: Implement OscillatorNode.setPeriodicWave()

Browse source
This commit is contained in:
Tim Ledbetter 2025-01-03 18:07:01 +00:00 • committed by Tim Ledbetter
parent acbae1b118
commit 8c4e4ec31b
Notes: github-actions[bot] 2025-01-04 10:13:24 +00:00
6 changed files with 205 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

32
Libraries/LibWeb/WebAudio/OscillatorNode.cpp
View file

@ -1,5 +1,6 @@
/*
* Copyright (c) 2024, Shannon Booth <shannon@serenityos.org>
* Copyright (c) 2025, Tim Ledbetter <tim.ledbetter@ladybird.org>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -25,9 +26,14 @@ WebIDL::ExceptionOr<GC::Ref<OscillatorNode>> OscillatorNode::create(JS::Realm& r
// https://webaudio.github.io/web-audio-api/#dom-oscillatornode-oscillatornode
WebIDL::ExceptionOr<GC::Ref<OscillatorNode>> OscillatorNode::construct_impl(JS::Realm& realm, GC::Ref<BaseAudioContext> context, OscillatorOptions const& options)
{
TRY(verify_valid_type(realm, options.type));
if (options.type == Bindings::OscillatorType::Custom && !options.periodic_wave)
return WebIDL::InvalidStateError::create(realm, "Oscillator node type 'custom' requires PeriodicWave to be provided"_string);
auto node = realm.create<OscillatorNode>(realm, context, options);
if (options.type == Bindings::OscillatorType::Custom)
node->set_periodic_wave(options.periodic_wave);
// Default options for channel count and interpretation
// https://webaudio.github.io/web-audio-api/#OscillatorNode
AudioNodeDefaultOptions default_options;
@ -56,24 +62,23 @@ Bindings::OscillatorType OscillatorNode::type() const
}
// https://webaudio.github.io/web-audio-api/#dom-oscillatornode-type
WebIDL::ExceptionOr<void> OscillatorNode::verify_valid_type(JS::Realm& realm, Bindings::OscillatorType type)
WebIDL::ExceptionOr<void> OscillatorNode::set_type(Bindings::OscillatorType type)
{
// The shape of the periodic waveform. It may directly be set to any of the type constant values except
// for "custom". ⌛ Doing so MUST throw an InvalidStateError exception. The setPeriodicWave() method can
// be used to set a custom waveform, which results in this attribute being set to "custom". The default
// value is "sine". When this attribute is set, the phase of the oscillator MUST be conserved.
if (type == Bindings::OscillatorType::Custom)
return WebIDL::InvalidStateError::create(realm, "Oscillator node type cannot be set to 'custom'"_string);
if (type == Bindings::OscillatorType::Custom && m_type != Bindings::OscillatorType::Custom)
return WebIDL::InvalidStateError::create(realm(), "Oscillator node type cannot be changed to 'custom'"_string);
// FIXME: An appropriate PeriodicWave should be set here based on the given type.
set_periodic_wave(nullptr);
m_type = type;
return {};
}
// https://webaudio.github.io/web-audio-api/#dom-oscillatornode-type
WebIDL::ExceptionOr<void> OscillatorNode::set_type(Bindings::OscillatorType type)
// https://webaudio.github.io/web-audio-api/#dom-oscillatornode-setperiodicwave
void OscillatorNode::set_periodic_wave(GC::Ptr<PeriodicWave> periodic_wave)
{
TRY(verify_valid_type(realm(), type));
m_type = type;
return {};
m_periodic_wave = periodic_wave;
m_type = Bindings::OscillatorType::Custom;
}
void OscillatorNode::initialize(JS::Realm& realm)
@ -87,6 +92,7 @@ void OscillatorNode::visit_edges(Cell::Visitor& visitor)
Base::visit_edges(visitor);
visitor.visit(m_frequency);
visitor.visit(m_detune);
visitor.visit(m_periodic_wave);
}
}