mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-29 04:09:13 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibCore: Don't reserve 2 KiB of stack memory when processing event queue

Browse source 
The inline capacity on ThreadEventQueue::Private::queued_events caused
us to reserve (and importantly, not initialize!) 2 KiB of stack memory
when entering ThreadEventQueue::process().

This was causing any leftover pointers to GC-allocated objects within
that memory range to keep those objects alive, even when all other
references were gone.
This commit is contained in:
Andreas Kling 2024-11-10 15:11:19 +01:00 • committed by Andreas Kling
commit 8c809fa5ee
Notes: github-actions[bot] 2024-11-10 18:14:02 +00:00
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibCore/ThreadEventQueue.cpp
View file

@ -35,7 +35,7 @@ struct ThreadEventQueue::Private {
}; };
Threading::Mutex mutex; Threading::Mutex mutex;
Vector<QueuedEvent, 128> queued_events; Vector<QueuedEvent> queued_events;
Vector<NonnullRefPtr<Promise<NonnullRefPtr<EventReceiver>>>, 16> pending_promises; Vector<NonnullRefPtr<Promise<NonnullRefPtr<EventReceiver>>>, 16> pending_promises;
bool warned_promise_count { false }; bool warned_promise_count { false };
}; };