mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-09-22 17:29:01 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibMedia: Remove the duration field from Track::VideoData

Browse source 
Most demuxer users will only care about the whole file's duration
anyway, so this field doesn't really do us any good.
This commit is contained in:
Zaggy1024 2025-09-11 18:32:23 -05:00 • committed by Jelle Raaijmakers
commit 8d64e72655
Notes: github-actions[bot] 2025-09-12 09:25:18 +00:00
4 changed files with 7 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Libraries/LibMedia/Containers/Matroska/MatroskaDemuxer.cpp
View file

@ -48,8 +48,12 @@ DecoderErrorOr<Vector<Track>> MatroskaDemuxer::get_tracks_for_type(TrackType typ
switch (type) { switch (type) {
case TrackType::Video: case TrackType::Video:
if (auto video_track = track_entry.video_track(); video_track.has_value()) if (auto video_track = track_entry.video_track(); video_track.has_value()) {
track.set_video_data({ TRY(duration(track)), video_track->pixel_width, video_track->pixel_height }); track.set_video_data({
.pixel_width = video_track->pixel_width,
.pixel_height = video_track->pixel_height
});
}
break; break;
default: default:
break; break;

1
Libraries/LibMedia/FFmpeg/FFmpegDemuxer.cpp
View file

@ -116,7 +116,6 @@ DecoderErrorOr<Vector<Track>> FFmpegDemuxer::get_tracks_for_type(TrackType type)
if (type == TrackType::Video) { if (type == TrackType::Video) {
track.set_video_data({ track.set_video_data({
.duration = TRY(duration_of_track(track)),
.pixel_width = static_cast<u64>(stream->codecpar->width), .pixel_width = static_cast<u64>(stream->codecpar->width),
.pixel_height = static_cast<u64>(stream->codecpar->height), .pixel_height = static_cast<u64>(stream->codecpar->height),
}); });

1
Libraries/LibMedia/Track.h
View file

@ -22,7 +22,6 @@ enum class TrackType : u32 {
class Track { class Track {
struct VideoData { struct VideoData {
AK::Duration duration {};
u64 pixel_width { 0 }; u64 pixel_width { 0 };
u64 pixel_height { 0 }; u64 pixel_height { 0 };
}; };

2
Libraries/LibWeb/HTML/VideoTrack.cpp
View file

@ -110,7 +110,7 @@ AK::Duration VideoTrack::position() const
AK::Duration VideoTrack::duration() const AK::Duration VideoTrack::duration() const
{ {
return m_playback_manager->selected_video_track().video_data().duration; return m_playback_manager->duration();
} }
void VideoTrack::seek(AK::Duration position, MediaSeekMode seek_mode) void VideoTrack::seek(AK::Duration position, MediaSeekMode seek_mode)