LibURL: Remove URL's valid state

No code now relies on using URL's valid state. A URL can still be _technically_ invalid through use of the URL constructor or by directly changing URL fields. However, all URLs should be constructed through the URL parser, and we should ideally be getting rid of the default constructor at some stage. Also, any code which is manually setting URL fields need to be aware that this is full of pitfalls since there are many different forms of canonicalization which is bypassed by not going through the URL parser.
Author: https://github.com/shannonbooth Commit: 8e37cd2f71 Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/4401 Reviewed-by: https://github.com/trflynn89 ✅
2025-08-07 00:29:15 +00:00 · 2025-04-19 17:11:24 +12:00 · 2025-04-19 17:11:24 +12:00 · 8e37cd2f71 · 2025-04-19 11:19:39 +00:00
commit 8e37cd2f71
parent 8d0fb91450
4 changed files with 2 additions and 57 deletions
--- a/Libraries/LibURL/Parser.cpp
+++ b/Libraries/LibURL/Parser.cpp
@ -1663,7 +1663,6 @@ Optional<URL> Parser::basic_parse(StringView raw_input, Optional<URL const&> bas
        ++iterator;
    }

-    url->m_data->valid = true;
    dbgln_if(URL_PARSER_DEBUG, "URL::Parser::basic_parse: Parsed URL to be '{}'.", url->serialize());

    // 10. Return url.