mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-01 13:49:16 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

Kernel/VirtIO: Don't expose constructors as public method

Browse source 
This leads to a bad pattern where anyone could create an RNG or a
Console object. Instead, let's just use the common pattern of a static
method to instantiate a new object and return it wrapped by a
NonnullRefPtr.
This commit is contained in:
Liav A 2021-08-27 12:32:05 +03:00 • committed by Andreas Kling
commit 8e90a4fd1c
Notes: sideshowbarker 2024-07-18 04:59:47 +09:00
5 changed files with 16 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Kernel/Bus/VirtIO/RNG.cpp
View file

@ -9,6 +9,11 @@
namespace Kernel::VirtIO {
UNMAP_AFTER_INIT NonnullRefPtr<RNG> RNG::must_create(PCI::Address address)
{
return adopt_ref_if_nonnull(new RNG(address)).release_nonnull();
}
UNMAP_AFTER_INIT RNG::RNG(PCI::Address address)
: VirtIO::Device(address)
{