mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-17 07:50:04 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibJS: Propogate allocation errors in BigInt constructor functions

Browse source
This commit is contained in:
Jess 2025-02-19 04:06:39 +13:00 • committed by Tim Flynn
commit 8ed7dee0f0
Notes: github-actions[bot] 2025-02-19 14:01:55 +00:00
3 changed files with 14 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibJS/Runtime/BigIntConstructor.cpp
View file

@ -75,7 +75,7 @@ JS_DEFINE_NATIVE_FUNCTION(BigIntConstructor::as_int_n)
// 3. Let mod be ℝ(bigint) modulo 2^bits. // 3. Let mod be ℝ(bigint) modulo 2^bits.
// FIXME: For large values of `bits`, this can likely be improved with a SignedBigInteger API to // FIXME: For large values of `bits`, this can likely be improved with a SignedBigInteger API to
// drop the most significant bits. // drop the most significant bits.
auto bits_shift_left = BIGINT_ONE.shift_left(bits); auto bits_shift_left = TRY_OR_THROW_OOM(vm, BIGINT_ONE.try_shift_left(bits));
auto mod = modulo(bigint->big_integer(), bits_shift_left); auto mod = modulo(bigint->big_integer(), bits_shift_left);
// 4. If mod ≥ 2^(bits-1), return ℤ(mod - 2^bits); otherwise, return ℤ(mod). // 4. If mod ≥ 2^(bits-1), return ℤ(mod - 2^bits); otherwise, return ℤ(mod).
@ -101,7 +101,7 @@ JS_DEFINE_NATIVE_FUNCTION(BigIntConstructor::as_uint_n)
// 3. Return the BigInt value that represents ℝ(bigint) modulo 2bits. // 3. Return the BigInt value that represents ℝ(bigint) modulo 2bits.
// FIXME: For large values of `bits`, this can likely be improved with a SignedBigInteger API to // FIXME: For large values of `bits`, this can likely be improved with a SignedBigInteger API to
// drop the most significant bits. // drop the most significant bits.
return BigInt::create(vm, modulo(bigint->big_integer(), BIGINT_ONE.shift_left(bits))); return BigInt::create(vm, modulo(bigint->big_integer(), TRY_OR_THROW_OOM(vm, BIGINT_ONE.try_shift_left(bits))));
} }
} }

6
Libraries/LibJS/Tests/builtins/BigInt/BigInt.asIntN.js
View file

@ -22,6 +22,12 @@ describe("errors", () => {
BigInt.asIntN(1, "foo"); BigInt.asIntN(1, "foo");
}).toThrowWithMessage(SyntaxError, "Invalid value for BigInt: foo"); }).toThrowWithMessage(SyntaxError, "Invalid value for BigInt: foo");
}); });
test("large allocation", () => {
expect(() => {
BigInt.asIntN(0x4000000000000, 1n);
}).toThrowWithMessage(InternalError, "Out of memory");
});
}); });
describe("correct behavior", () => { describe("correct behavior", () => {

6
Libraries/LibJS/Tests/builtins/BigInt/BigInt.asUintN.js
View file

@ -22,6 +22,12 @@ describe("errors", () => {
BigInt.asUintN(1, "foo"); BigInt.asUintN(1, "foo");
}).toThrowWithMessage(SyntaxError, "Invalid value for BigInt: foo"); }).toThrowWithMessage(SyntaxError, "Invalid value for BigInt: foo");
}); });
test("large allocation", () => {
expect(() => {
BigInt.asUintN(0x4000000000000, 1n);
}).toThrowWithMessage(InternalError, "Out of memory");
});
}); });
describe("correct behavior", () => { describe("correct behavior", () => {