From 8edaec79dea2f39a31ee97738dfa2e74911efe26 Mon Sep 17 00:00:00 2001
From: Andrew Kaster <andrew@ladybird.org>
Date: Fri, 4 Oct 2024 16:11:00 -0600
Subject: [PATCH] LibWeb: Add a feature to LibWeb tests to fail on unhandled
 exceptions

Previously, if there was an unhandled exception in an async test, it
might fail to call done() and timeout. Now we have a default "error"
handler to catch unhandled exceptions and fail the test. A few tests
want to actually test the behavior of window.onerror, so they need an
escape hatch.
---
 .../LibWeb/Text/expected/all-window-properties.txt |  1 +
 Tests/LibWeb/Text/input/HTML/Window-onerror.html   |  3 +++
 .../WindowOrWorkerGlobalScope-reportError.html     |  2 ++
 Tests/LibWeb/Text/input/include.js                 | 14 ++++++++++++++
 4 files changed, 20 insertions(+)

diff --git a/Tests/LibWeb/Text/expected/all-window-properties.txt b/Tests/LibWeb/Text/expected/all-window-properties.txt
index a384a840793..8fa706e12ad 100644
--- a/Tests/LibWeb/Text/expected/all-window-properties.txt
+++ b/Tests/LibWeb/Text/expected/all-window-properties.txt
@@ -395,6 +395,7 @@ asyncTest
 printElement
 println
 promiseTest
+removeTestErrorHandler
 spoofCurrentURL
 test
 timeout
diff --git a/Tests/LibWeb/Text/input/HTML/Window-onerror.html b/Tests/LibWeb/Text/input/HTML/Window-onerror.html
index 525f1f70a61..318ab4fd6d2 100644
--- a/Tests/LibWeb/Text/input/HTML/Window-onerror.html
+++ b/Tests/LibWeb/Text/input/HTML/Window-onerror.html
@@ -2,6 +2,9 @@
 <script src="../include.js"></script>
 <script>
     asyncTest(done => {
+
+        removeTestErrorHandler()
+
         window.addEventListener("error", (event) => {
             println(`onerror event fired: ${event.error}`);
             done();
diff --git a/Tests/LibWeb/Text/input/HTML/WindowOrWorkerGlobalScope-reportError.html b/Tests/LibWeb/Text/input/HTML/WindowOrWorkerGlobalScope-reportError.html
index e78751da48d..7021add9de5 100644
--- a/Tests/LibWeb/Text/input/HTML/WindowOrWorkerGlobalScope-reportError.html
+++ b/Tests/LibWeb/Text/input/HTML/WindowOrWorkerGlobalScope-reportError.html
@@ -1,6 +1,8 @@
 <script src="../include.js"></script>
 <script>
     test(() => {
+        removeTestErrorHandler()
+
         window.onerror = (message, filename, lineno, colno, error) => {
             println(`message = ${message}`);
             println(`lineno = ${lineno}`);
diff --git a/Tests/LibWeb/Text/input/include.js b/Tests/LibWeb/Text/input/include.js
index dc60ffa5c71..7ac4f1d0923 100644
--- a/Tests/LibWeb/Text/input/include.js
+++ b/Tests/LibWeb/Text/input/include.js
@@ -52,6 +52,20 @@ function timeout(ms) {
     return promise;
 }
 
+const __testErrorHandlerController = new AbortController();
+window.addEventListener(
+    "error",
+    event => {
+        println(`Uncaught Error In Test: ${event.message}`);
+        __finishTest();
+    },
+    { signal: __testErrorHandlerController.signal }
+);
+
+function removeTestErrorHandler() {
+    __testErrorHandlerController.abort();
+}
+
 document.addEventListener("DOMContentLoaded", function () {
     __outputElement = document.createElement("pre");
     __outputElement.setAttribute("id", "out");