diff --git a/Libraries/LibWeb/HTML/HTMLOptionElement.cpp b/Libraries/LibWeb/HTML/HTMLOptionElement.cpp
index 87995bb31df..8dc7be8a547 100644
--- a/Libraries/LibWeb/HTML/HTMLOptionElement.cpp
+++ b/Libraries/LibWeb/HTML/HTMLOptionElement.cpp
@@ -114,6 +114,13 @@ String HTMLOptionElement::label() const
void HTMLOptionElement::set_label(String const& label)
{
MUST(set_attribute(HTML::AttributeNames::label, label));
+
+ // NOTE: This option's select element may need to show different contents now.
+ if (selected()) {
+ if (auto select_element = first_ancestor_of_type()) {
+ select_element->update_inner_text_element({});
+ }
+ }
}
// https://html.spec.whatwg.org/multipage/form-elements.html#dom-option-text
diff --git a/Libraries/LibWeb/HTML/HTMLSelectElement.cpp b/Libraries/LibWeb/HTML/HTMLSelectElement.cpp
index 3a0607d6415..a080533e55f 100644
--- a/Libraries/LibWeb/HTML/HTMLSelectElement.cpp
+++ b/Libraries/LibWeb/HTML/HTMLSelectElement.cpp
@@ -413,7 +413,7 @@ void HTMLSelectElement::show_the_picker_if_applicable()
for (auto const& child : opt_group_element.children_as_vector()) {
if (is(*child)) {
auto& option_element = verify_cast(*child);
- option_group_items.append(SelectItemOption { id_counter++, option_element.selected(), option_element.disabled(), option_element, strip_newlines(option_element.text_content()), option_element.value() });
+ option_group_items.append(SelectItemOption { id_counter++, option_element.selected(), option_element.disabled(), option_element, strip_newlines(option_element.label()), option_element.value() });
}
}
m_select_items.append(SelectItemOptionGroup { opt_group_element.get_attribute(AttributeNames::label).value_or(String {}), option_group_items });
@@ -421,7 +421,7 @@ void HTMLSelectElement::show_the_picker_if_applicable()
if (is(*child)) {
auto& option_element = verify_cast(*child);
- m_select_items.append(SelectItemOption { id_counter++, option_element.selected(), option_element.disabled(), option_element, strip_newlines(option_element.text_content()), option_element.value() });
+ m_select_items.append(SelectItemOption { id_counter++, option_element.selected(), option_element.disabled(), option_element, strip_newlines(option_element.label()), option_element.value() });
}
if (is(*child))
@@ -567,15 +567,21 @@ void HTMLSelectElement::create_shadow_tree_if_needed()
update_inner_text_element();
}
+void HTMLSelectElement::update_inner_text_element(Badge)
+{
+ update_inner_text_element();
+}
+
+// FIXME: This needs to be called any time the selected option's children are modified.
void HTMLSelectElement::update_inner_text_element()
{
if (!m_inner_text_element)
return;
- // Update inner text element to text content of selected option
+ // Update inner text element to the label of the selected option
for (auto const& option_element : list_of_options()) {
if (option_element->selected()) {
- m_inner_text_element->set_text_content(strip_newlines(option_element->text_content()));
+ m_inner_text_element->set_text_content(strip_newlines(option_element->label()));
return;
}
}
diff --git a/Libraries/LibWeb/HTML/HTMLSelectElement.h b/Libraries/LibWeb/HTML/HTMLSelectElement.h
index 616a025046b..640c081c196 100644
--- a/Libraries/LibWeb/HTML/HTMLSelectElement.h
+++ b/Libraries/LibWeb/HTML/HTMLSelectElement.h
@@ -96,6 +96,8 @@ public:
void update_selectedness();
+ void update_inner_text_element(Badge);
+
private:
HTMLSelectElement(DOM::Document&, DOM::QualifiedName);
diff --git a/Tests/LibWeb/Ref/expected/select-option-use-label.html b/Tests/LibWeb/Ref/expected/select-option-use-label.html
new file mode 100644
index 00000000000..aad9e583640
--- /dev/null
+++ b/Tests/LibWeb/Ref/expected/select-option-use-label.html
@@ -0,0 +1,4 @@
+
+
diff --git a/Tests/LibWeb/Ref/input/select-option-use-label.html b/Tests/LibWeb/Ref/input/select-option-use-label.html
new file mode 100644
index 00000000000..c26b6d1e2a9
--- /dev/null
+++ b/Tests/LibWeb/Ref/input/select-option-use-label.html
@@ -0,0 +1,5 @@
+
+
+