From 8f21513902b3d9e596a7ea2da15ea9cabaf96046 Mon Sep 17 00:00:00 2001 From: Sam Atkins Date: Wed, 6 Nov 2024 12:44:38 +0000 Subject: [PATCH] Tests: Re-import tests that used ahem.css This causes 36 new subtests to pass locally. :^) Unfortunately at least one of these is flaky when it's able to load the font file, apparently because we don't wait for the font and its stylesheet to actually load before the tests run. --- Tests/LibWeb/TestConfig.ini | 3 + .../grid-columns-rows-get-set-multiple.txt | 34 +- .../grid-content-sized-columns-resolution.txt | 45 +-- .../flex-item-compressible-001.html | 2 +- .../flex-item-compressible-002.html | 2 +- .../flex-one-sets-flex-basis-to-zero-px.html | 2 +- .../css-flexbox/hittest-anonymous-box.html | 2 +- .../css-flexbox/hittest-before-pseudo.html | 2 +- .../intrinsic-size/row-use-cases-001.html | 2 +- .../text-as-flexitem-size-001.html | 2 +- .../grid-columns-rows-get-set-multiple.html | 8 +- ...grid-content-sized-columns-resolution.html | 6 +- .../wpt-import/css/support/alignment.css | 367 ++++++++++++++++++ .../input/wpt-import/css/support/grid.css | 289 ++++++++++++++ .../css/support/width-keyword-classes.css | 43 ++ 15 files changed, 756 insertions(+), 53 deletions(-) create mode 100644 Tests/LibWeb/Text/input/wpt-import/css/support/alignment.css create mode 100644 Tests/LibWeb/Text/input/wpt-import/css/support/grid.css create mode 100644 Tests/LibWeb/Text/input/wpt-import/css/support/width-keyword-classes.css diff --git a/Tests/LibWeb/TestConfig.ini b/Tests/LibWeb/TestConfig.ini index 897752efb5a..405eb45eb59 100644 --- a/Tests/LibWeb/TestConfig.ini +++ b/Tests/LibWeb/TestConfig.ini @@ -52,3 +52,6 @@ Text/input/wpt-import/html/infrastructure/safe-passing-of-structured-data/struct Text/input/wpt-import/html/infrastructure/safe-passing-of-structured-data/resources/echo-iframe.html Text/input/wpt-import/html/infrastructure/safe-passing-of-structured-data/resources/iframe-resizable-arraybuffer-helper.html Text/input/wpt-import/html/infrastructure/safe-passing-of-structured-data/resources/post-parent-type-error.html + +; Flaky, apparently due to font loading +Text/input/wpt-import/css/css-flexbox/flex-item-compressible-001.html diff --git a/Tests/LibWeb/Text/expected/wpt-import/css/css-grid/parsing/grid-columns-rows-get-set-multiple.txt b/Tests/LibWeb/Text/expected/wpt-import/css/css-grid/parsing/grid-columns-rows-get-set-multiple.txt index 9e447517713..eb465198983 100644 --- a/Tests/LibWeb/Text/expected/wpt-import/css/css-grid/parsing/grid-columns-rows-get-set-multiple.txt +++ b/Tests/LibWeb/Text/expected/wpt-import/css/css-grid/parsing/grid-columns-rows-get-set-multiple.txt @@ -6,27 +6,27 @@ Rerun Found 40 tests -8 Pass -32 Fail +23 Pass +17 Fail Details Result Test Name MessagePass Test getting grid-template-columns and grid-template-rows set through CSS for element 'gridWithFixedElement' : grid-template-columns = '7px 11px', grid-template-rows = '17px 2px' -Fail Test getting grid-template-columns and grid-template-rows set through CSS for element 'gridWithPercentElement' : grid-template-columns = '400px 800px', grid-template-rows = '150px 450px' +Pass Test getting grid-template-columns and grid-template-rows set through CSS for element 'gridWithPercentElement' : grid-template-columns = '400px 800px', grid-template-rows = '150px 450px' Fail Test getting grid-template-columns and grid-template-rows set through CSS for element 'gridWithPercentWithoutSize' : grid-template-columns = '3.5px 7px', grid-template-rows = '4px 12px' -Fail Test getting grid-template-columns and grid-template-rows set through CSS for element 'gridWithAutoElement' : grid-template-columns = '0px 17px', grid-template-rows = '0px 3px' -Fail Test getting grid-template-columns and grid-template-rows set through CSS for element 'gridWithEMElement' : grid-template-columns = '100px 120px', grid-template-rows = '150px 170px' -Fail Test getting grid-template-columns and grid-template-rows set through CSS for element 'gridWithThreeItems' : grid-template-columns = '15px 0px 100px', grid-template-rows = '120px 18px 0px' +Pass Test getting grid-template-columns and grid-template-rows set through CSS for element 'gridWithAutoElement' : grid-template-columns = '0px 17px', grid-template-rows = '0px 3px' +Pass Test getting grid-template-columns and grid-template-rows set through CSS for element 'gridWithEMElement' : grid-template-columns = '100px 120px', grid-template-rows = '150px 170px' +Pass Test getting grid-template-columns and grid-template-rows set through CSS for element 'gridWithThreeItems' : grid-template-columns = '15px 0px 100px', grid-template-rows = '120px 18px 0px' Fail Test getting grid-template-columns and grid-template-rows set through CSS for element 'gridWithFitContentAndFitAvailable' : grid-template-columns = 'none', grid-template-rows = 'none' -Fail Test getting grid-template-columns and grid-template-rows set through CSS for element 'gridWithMinMaxContent' : grid-template-columns = '0px 0px', grid-template-rows = '0px 0px' -Fail Test getting grid-template-columns and grid-template-rows set through CSS for element 'gridWithMinMaxContentWithChildrenElement' : grid-template-columns = '7px 17px', grid-template-rows = '16px 3px' -Fail Test getting grid-template-columns and grid-template-rows set through CSS for element 'gridWithMinMaxAndFixed' : grid-template-columns = '240px 15px', grid-template-rows = '120px 210px' -Fail Test getting grid-template-columns and grid-template-rows set through CSS for element 'gridWithMinMaxAndMinMaxContent' : grid-template-columns = '240px 15px', grid-template-rows = '120px 210px' -Fail Test getting grid-template-columns and grid-template-rows set through CSS for element 'gridWithFractionFraction' : grid-template-columns = '320px 480px', grid-template-rows = '225px 375px' -Fail Test getting grid-template-columns and grid-template-rows set through CSS for element 'gridWithFractionMinMax' : grid-template-columns = '45px 755px', grid-template-rows = '586px 14px' -Fail Test getting grid-template-columns and grid-template-rows set through CSS for element 'gridWithCalcCalc' : grid-template-columns = '200px 100px', grid-template-rows = '150px 75px' -Fail Test getting grid-template-columns and grid-template-rows set through CSS for element 'gridWithCalcAndFixed' : grid-template-columns = '400px 80px', grid-template-rows = '88px 150px' -Fail Test getting grid-template-columns and grid-template-rows set through CSS for element 'gridWithCalcAndMinMax' : grid-template-columns = '190px 80px', grid-template-rows = '150px 53px' -Fail Test getting grid-template-columns and grid-template-rows set through CSS for element 'gridWithCalcInsideMinMax' : grid-template-columns = '400px 120px', grid-template-rows = '150px 175px' -Fail Test getting grid-template-columns and grid-template-rows set through CSS for element 'gridWithAutoInsideMinMax' : grid-template-columns = '0px 30px', grid-template-rows = '132px 60px' +Pass Test getting grid-template-columns and grid-template-rows set through CSS for element 'gridWithMinMaxContent' : grid-template-columns = '0px 0px', grid-template-rows = '0px 0px' +Pass Test getting grid-template-columns and grid-template-rows set through CSS for element 'gridWithMinMaxContentWithChildrenElement' : grid-template-columns = '7px 17px', grid-template-rows = '16px 3px' +Pass Test getting grid-template-columns and grid-template-rows set through CSS for element 'gridWithMinMaxAndFixed' : grid-template-columns = '240px 15px', grid-template-rows = '120px 210px' +Pass Test getting grid-template-columns and grid-template-rows set through CSS for element 'gridWithMinMaxAndMinMaxContent' : grid-template-columns = '240px 15px', grid-template-rows = '120px 210px' +Pass Test getting grid-template-columns and grid-template-rows set through CSS for element 'gridWithFractionFraction' : grid-template-columns = '320px 480px', grid-template-rows = '225px 375px' +Pass Test getting grid-template-columns and grid-template-rows set through CSS for element 'gridWithFractionMinMax' : grid-template-columns = '45px 755px', grid-template-rows = '586px 14px' +Pass Test getting grid-template-columns and grid-template-rows set through CSS for element 'gridWithCalcCalc' : grid-template-columns = '200px 100px', grid-template-rows = '150px 75px' +Pass Test getting grid-template-columns and grid-template-rows set through CSS for element 'gridWithCalcAndFixed' : grid-template-columns = '400px 80px', grid-template-rows = '88px 150px' +Pass Test getting grid-template-columns and grid-template-rows set through CSS for element 'gridWithCalcAndMinMax' : grid-template-columns = '190px 80px', grid-template-rows = '150px 53px' +Pass Test getting grid-template-columns and grid-template-rows set through CSS for element 'gridWithCalcInsideMinMax' : grid-template-columns = '400px 120px', grid-template-rows = '150px 175px' +Pass Test getting grid-template-columns and grid-template-rows set through CSS for element 'gridWithAutoInsideMinMax' : grid-template-columns = '0px 30px', grid-template-rows = '132px 60px' Pass Test getting and setting grid-template-rows and grid-template-columns through JS: grid-template-columns = '18px 22px', element.style.gridTemplateColumns = '18px 22px', grid-template-rows = '66px 70px', element.style.gridTemplateRows = '66px 70px' Pass Test getting and setting grid-template-rows and grid-template-columns through JS: grid-template-columns = '440px 640px', element.style.gridTemplateColumns = '55% 80%', grid-template-rows = '240px 378px', element.style.gridTemplateRows = '40% 63%' Pass Test getting and setting grid-template-rows and grid-template-columns through JS: grid-template-columns = '0px 0px', element.style.gridTemplateColumns = 'auto auto', grid-template-rows = '0px 0px', element.style.gridTemplateRows = 'auto auto' diff --git a/Tests/LibWeb/Text/expected/wpt-import/css/css-grid/parsing/grid-content-sized-columns-resolution.txt b/Tests/LibWeb/Text/expected/wpt-import/css/css-grid/parsing/grid-content-sized-columns-resolution.txt index 4dcd1464965..139cfa534a9 100644 --- a/Tests/LibWeb/Text/expected/wpt-import/css/css-grid/parsing/grid-content-sized-columns-resolution.txt +++ b/Tests/LibWeb/Text/expected/wpt-import/css/css-grid/parsing/grid-content-sized-columns-resolution.txt @@ -6,47 +6,48 @@ Rerun Found 42 tests -42 Fail +21 Pass +21 Fail Details -Result Test Name MessageFail Element 'gridMinContentFixedAndAuto' grid-template-columns value computes to '15px 75px' -Fail Element 'gridAutoAndAuto' grid-template-columns value computes to '45px 45px' +Result Test Name MessagePass Element 'gridMinContentFixedAndAuto' grid-template-columns value computes to '15px 75px' +Pass Element 'gridAutoAndAuto' grid-template-columns value computes to '45px 45px' Fail Element 'gridMinContentAndMinContentFixed' grid-template-columns value computes to '20px 30px' -Fail Element 'gridMaxContentAndMinContent' grid-template-columns value computes to '70px 20px' -Fail Element 'gridFixedMinContentAndMaxContent' grid-template-columns value computes to '10px 80px' -Fail Element 'gridFixedMaxContentAndMinContent' grid-template-columns value computes to '60px 30px' +Pass Element 'gridMaxContentAndMinContent' grid-template-columns value computes to '70px 20px' +Pass Element 'gridFixedMinContentAndMaxContent' grid-template-columns value computes to '10px 80px' +Pass Element 'gridFixedMaxContentAndMinContent' grid-template-columns value computes to '60px 30px' Fail Element 'gridMinContentAndMaxContentFixed' grid-template-columns value computes to '20px 70px' Fail Element 'gridMaxContentFixedAndAuto' grid-template-columns value computes to '65px 25px' -Fail Element 'gridAutoMinContent' grid-template-columns value computes to '70px 20px' +Pass Element 'gridAutoMinContent' grid-template-columns value computes to '70px 20px' Fail Element 'gridAutoMaxContent' grid-template-columns value computes to '20px 70px' Fail Element 'gridMaxContentAndMinContentFixed' grid-template-columns value computes to '70px 20px' Fail Element 'gridMaxContentAndMaxContentFixed' grid-template-columns value computes to '55px 35px' -Fail Element 'gridMinContentFixedAndAutoUnsortedConstrained' grid-template-columns value computes to '0px 40px' -Fail Element 'gridAutoAndAutoUnsortedConstrained' grid-template-columns value computes to '10px 30px' -Fail Element 'gridMinContentAndMinContentFixedUnsortedConstrained' grid-template-columns value computes to '0px 40px' -Fail Element 'gridMaxContentAndMinContentUnsortedConstrained' grid-template-columns value computes to '0px 70px' +Pass Element 'gridMinContentFixedAndAutoUnsortedConstrained' grid-template-columns value computes to '0px 40px' +Pass Element 'gridAutoAndAutoUnsortedConstrained' grid-template-columns value computes to '10px 30px' +Pass Element 'gridMinContentAndMinContentFixedUnsortedConstrained' grid-template-columns value computes to '0px 40px' +Pass Element 'gridMaxContentAndMinContentUnsortedConstrained' grid-template-columns value computes to '0px 70px' Fail Element 'gridFixedMinContentAndMaxContentUnsortedConstrained' grid-template-columns value computes to '10px 70px' -Fail Element 'gridFixedMaxContentAndMinContentUnsortedConstrained' grid-template-columns value computes to '10px 40px' +Pass Element 'gridFixedMaxContentAndMinContentUnsortedConstrained' grid-template-columns value computes to '10px 40px' Fail Element 'gridMinContentAndMaxContentFixedUnsortedConstrained' grid-template-columns value computes to '0px 90px' Fail Element 'gridMaxContentFixedAndAutoUnsortedConstrained' grid-template-columns value computes to '10px 40px' -Fail Element 'gridAutoMinContentUnsortedConstrained' grid-template-columns value computes to '0px 60px' +Pass Element 'gridAutoMinContentUnsortedConstrained' grid-template-columns value computes to '0px 60px' Fail Element 'gridAutoMaxContentUnsortedConstrained' grid-template-columns value computes to '0px 90px' Fail Element 'gridMaxContentAndMinContentFixedUnsortedConstrained' grid-template-columns value computes to '50px 40px' Fail Element 'gridMaxContentAndMaxContentFixedUnsortedConstrained' grid-template-columns value computes to '40px 70px' -Fail Element 'gridMinContentFixedAndAutoUnsorted' grid-template-columns value computes to '15px 90px' +Pass Element 'gridMinContentFixedAndAutoUnsorted' grid-template-columns value computes to '15px 90px' Fail Element 'gridAutoAndAutoUnsorted' grid-template-columns value computes to '60px 30px' -Fail Element 'gridMinContentAndMinContentFixedUnsorted' grid-template-columns value computes to '0px 40px' -Fail Element 'gridMaxContentAndMinContentUnsorted' grid-template-columns value computes to '0px 70px' +Pass Element 'gridMinContentAndMinContentFixedUnsorted' grid-template-columns value computes to '0px 40px' +Pass Element 'gridMaxContentAndMinContentUnsorted' grid-template-columns value computes to '0px 70px' Fail Element 'gridFixedMinContentAndMaxContentUnsorted' grid-template-columns value computes to '10px 70px' -Fail Element 'gridFixedMaxContentAndMinContentUnsorted' grid-template-columns value computes to '50px 40px' +Pass Element 'gridFixedMaxContentAndMinContentUnsorted' grid-template-columns value computes to '50px 40px' Fail Element 'gridMinContentAndMaxContentFixedUnsorted' grid-template-columns value computes to '0px 90px' -Fail Element 'gridMaxContentFixedAndAutoUnsorted' grid-template-columns value computes to '15px 70px' -Fail Element 'gridAutoMinContentUnsorted' grid-template-columns value computes to '50px 60px' +Pass Element 'gridMaxContentFixedAndAutoUnsorted' grid-template-columns value computes to '15px 70px' +Pass Element 'gridAutoMinContentUnsorted' grid-template-columns value computes to '50px 60px' Fail Element 'gridAutoMaxContentUnsorted' grid-template-columns value computes to '0px 90px' -Fail Element 'gridMaxContentAndMinContentFixedUnsorted' grid-template-columns value computes to '50px 40px' -Fail Element 'gridMaxContentAndMaxContentFixedUnsorted' grid-template-columns value computes to '40px 70px' +Pass Element 'gridMaxContentAndMinContentFixedUnsorted' grid-template-columns value computes to '50px 40px' +Pass Element 'gridMaxContentAndMaxContentFixedUnsorted' grid-template-columns value computes to '40px 70px' Fail Element 'gridMinContentFixedAndAutoAboveLimits' grid-template-columns value computes to '15px 95px' Fail Element 'gridMaxContentFixedAndAutoAboveLimits' grid-template-columns value computes to '15px 135px' Fail Element 'gridMinContentFixedAndFixedFixedAndAuto' grid-template-columns value computes to '20px 20px 60px' Fail Element 'gridAutoAndFixedFixedAndMaxContentFixed' grid-template-columns value computes to '110px 20px 20px' -Fail Element 'gridMaxContentAndMaxContentFixedAndMaxContent' grid-template-columns value computes to '70px 20px 50px' +Pass Element 'gridMaxContentAndMaxContentFixedAndMaxContent' grid-template-columns value computes to '70px 20px 50px' Fail Element 'gridAutoAndMinContentFixedAndMinContent' grid-template-columns value computes to '55px 30px 65px' \ No newline at end of file diff --git a/Tests/LibWeb/Text/input/wpt-import/css/css-flexbox/flex-item-compressible-001.html b/Tests/LibWeb/Text/input/wpt-import/css/css-flexbox/flex-item-compressible-001.html index dc55f9b7d2b..54f94ec5772 100644 --- a/Tests/LibWeb/Text/input/wpt-import/css/css-flexbox/flex-item-compressible-001.html +++ b/Tests/LibWeb/Text/input/wpt-import/css/css-flexbox/flex-item-compressible-001.html @@ -11,7 +11,7 @@ - + diff --git a/Tests/LibWeb/Text/input/wpt-import/css/css-flexbox/flex-item-compressible-002.html b/Tests/LibWeb/Text/input/wpt-import/css/css-flexbox/flex-item-compressible-002.html index c5095305ec6..61ca14b914d 100644 --- a/Tests/LibWeb/Text/input/wpt-import/css/css-flexbox/flex-item-compressible-002.html +++ b/Tests/LibWeb/Text/input/wpt-import/css/css-flexbox/flex-item-compressible-002.html @@ -11,7 +11,7 @@ - + diff --git a/Tests/LibWeb/Text/input/wpt-import/css/css-flexbox/flex-one-sets-flex-basis-to-zero-px.html b/Tests/LibWeb/Text/input/wpt-import/css/css-flexbox/flex-one-sets-flex-basis-to-zero-px.html index 72dcf830f87..54e71370d70 100644 --- a/Tests/LibWeb/Text/input/wpt-import/css/css-flexbox/flex-one-sets-flex-basis-to-zero-px.html +++ b/Tests/LibWeb/Text/input/wpt-import/css/css-flexbox/flex-one-sets-flex-basis-to-zero-px.html @@ -3,7 +3,7 @@ CSS Flexbox: flex-basis with zero pixel - + - +