mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-01 13:49:16 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibJS: Integrate Temporal.Duration into Intl.DurationFormat

Browse source 
This is a normative change in the Temporal proposal. See:
2d97205
This commit is contained in:
Timothy Flynn 2025-02-28 13:36:22 -05:00 • committed by Andreas Kling
commit 8f51d1dd04
Notes: github-actions[bot] 2025-03-01 13:50:25 +00:00
6 changed files with 56 additions and 161 deletions
Download patch file Download diff file Expand all files Collapse all files

17
Libraries/LibJS/Tests/builtins/Intl/DurationFormat/DurationFormat.prototype.format.js
View file

@ -163,29 +163,36 @@ describe("correct behavior", () => {
};
expect(en.format(duration)).toBe("0:00:9007200.256743991");
});
test("format Temporal Duration objects", () => {
const duration = Temporal.Duration.from("P1Y2M3W4DT5H6M7S");
const en = new Intl.DurationFormat("en", { style: "digital" });
expect(en.format(duration)).toBe("1 yr, 2 mths, 3 wks, 4 days, 5:06:07");
});
});
describe("errors", () => {
test("non-object duration records", () => {
expect(() => {
new Intl.DurationFormat().format("hello");
}).toThrowWithMessage(RangeError, "is not an object");
}).toThrowWithMessage(RangeError, "Invalid duration string 'hello");
[-100, Infinity, NaN, 152n, Symbol("foo"), true, null, undefined].forEach(value => {
expect(() => {
new Intl.DurationFormat().format(value);
}).toThrowWithMessage(TypeError, "is not an object");
}).toThrowWithMessage(TypeError, "is not a string");
});
});
test("empty duration record", () => {
expect(() => {
new Intl.DurationFormat().format({});
}).toThrowWithMessage(TypeError, "Invalid duration-like object");
}).toThrowWithMessage(TypeError, "Invalid duration");
expect(() => {
new Intl.DurationFormat().format({ foo: 123 });
}).toThrowWithMessage(TypeError, "Invalid duration-like object");
}).toThrowWithMessage(TypeError, "Invalid duration");
});
test("non-integral duration fields", () => {
@ -220,6 +227,6 @@ describe("errors", () => {
test("inconsistent field signs", () => {
expect(() => {
new Intl.DurationFormat().format({ years: 1, months: -1 });
}).toThrowWithMessage(RangeError, "Invalid duration-like object");
}).toThrowWithMessage(RangeError, "Invalid duration");
});
});

10
Libraries/LibJS/Tests/builtins/Intl/DurationFormat/DurationFormat.prototype.formatToParts.js
View file

@ -477,23 +477,23 @@ describe("errors", () => {
test("non-object duration records", () => {
expect(() => {
new Intl.DurationFormat().formatToParts("hello");
}).toThrowWithMessage(RangeError, "is not an object");
}).toThrowWithMessage(RangeError, "Invalid duration string 'hello");
[-100, Infinity, NaN, 152n, Symbol("foo"), true, null, undefined].forEach(value => {
expect(() => {
new Intl.DurationFormat().formatToParts(value);
}).toThrowWithMessage(TypeError, "is not an object");
}).toThrowWithMessage(TypeError, "is not a string");
});
});
test("empty duration record", () => {
expect(() => {
new Intl.DurationFormat().formatToParts({});
}).toThrowWithMessage(TypeError, "Invalid duration-like object");
}).toThrowWithMessage(TypeError, "Invalid duration");
expect(() => {
new Intl.DurationFormat().formatToParts({ foo: 123 });
}).toThrowWithMessage(TypeError, "Invalid duration-like object");
}).toThrowWithMessage(TypeError, "Invalid duration");
});
test("non-integral duration fields", () => {
@ -528,6 +528,6 @@ describe("errors", () => {
test("inconsistent field signs", () => {
expect(() => {
new Intl.DurationFormat().formatToParts({ years: 1, months: -1 });
}).toThrowWithMessage(RangeError, "Invalid duration-like object");
}).toThrowWithMessage(RangeError, "Invalid duration");
});
});