From 8f6169859d0d6495d67e77b6106b38bd0d73aafb Mon Sep 17 00:00:00 2001 From: Timothy Flynn Date: Sat, 8 Mar 2025 12:10:27 -0500 Subject: [PATCH] LibWebSocket: Remove meaningless `const&&` Message constructor This results in an ambiguity error in an upcoming commit. --- Libraries/LibWebSocket/Message.h | 8 +------- Libraries/LibWebSocket/WebSocket.cpp | 4 ++-- 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/Libraries/LibWebSocket/Message.h b/Libraries/LibWebSocket/Message.h index 811d037faf8..fe3343bc13b 100644 --- a/Libraries/LibWebSocket/Message.h +++ b/Libraries/LibWebSocket/Message.h @@ -20,13 +20,7 @@ public: { } - explicit Message(ByteBuffer data, bool is_text) - : m_is_text(is_text) - , m_data(move(data)) - { - } - - explicit Message(ByteBuffer const&& data, bool is_text) + Message(ByteBuffer data, bool is_text) : m_is_text(is_text) , m_data(move(data)) { diff --git a/Libraries/LibWebSocket/WebSocket.cpp b/Libraries/LibWebSocket/WebSocket.cpp index 9024e5410c7..cf2548b084a 100644 --- a/Libraries/LibWebSocket/WebSocket.cpp +++ b/Libraries/LibWebSocket/WebSocket.cpp @@ -525,11 +525,11 @@ void WebSocket::read_frame() m_fragmented_data_buffer.clear(); } if (op_code == WebSocket::OpCode::Text) { - notify_message(Message(payload, true)); + notify_message(Message(move(payload), true)); return; } if (op_code == WebSocket::OpCode::Binary) { - notify_message(Message(payload, false)); + notify_message(Message(move(payload), false)); return; } dbgln("Websocket: Found unknown opcode {}", (u8)op_code);