mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-30 12:49:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibURL+LibWeb: Make URL serialization return a String

Browse source 
This can only ever fail from OOM, and will never by string containing
random byte sequences.
This commit is contained in:
Shannon Booth 2024-11-23 20:10:34 +13:00 • committed by Andreas Kling
commit 8f6fe1de83
Notes: github-actions[bot] 2024-11-23 15:44:52 +00:00
15 changed files with 24 additions and 30 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Libraries/LibURL/Origin.cpp
View file

@ -10,11 +10,11 @@
namespace URL {
// https://html.spec.whatwg.org/multipage/origin.html#ascii-serialisation-of-an-origin
ByteString Origin::serialize() const
String Origin::serialize() const
{
// 1. If origin is an opaque origin, then return "null"
if (is_opaque())
return "null";
return "null"_string;
// 2. Otherwise, let result be origin's scheme.
StringBuilder result;
@ -24,15 +24,16 @@ ByteString Origin::serialize() const
result.append("://"sv);
// 4. Append origin's host, serialized, to result.
result.append(Parser::serialize_host(host()).release_value_but_fixme_should_propagate_errors().to_byte_string());
result.append(MUST(Parser::serialize_host(host())));
// 5. If origin's port is non-null, append a U+003A COLON character (:), and origin's port, serialized, to result.
if (port().has_value()) {
result.append(':');
result.append(ByteString::number(*port()));
result.append(String::number(*port()));
}
// 6. Return result
return result.to_byte_string();
return result.to_string_without_validation();
}
}