LibJS+LibWeb: Make HTML::Script GC-allocated

This allows the garbage collector to keep HTML::Script objects alive and fixes a bug where a HTMLScriptElement could get GC'd while its code was executing.
Author: https://github.com/awesomekling Commit: 8f9ed415a0 Pull-request: https://github.com/SerenityOS/serenity/pull/14816 Reviewed-by: https://github.com/ADKaster Reviewed-by: https://github.com/linusg ✅
2025-06-02 00:13:02 +00:00 · 2022-09-05 14:32:33 +02:00 · 2022-09-05 14:32:33 +02:00 · 8f9ed415a0 · 2024-07-17 07:23:32 +09:00
commit 8f9ed415a0
parent 00c8f07192
6 changed files with 35 additions and 12 deletions
--- a/Userland/Libraries/LibWeb/HTML/HTMLScriptElement.h
+++ b/Userland/Libraries/LibWeb/HTML/HTMLScriptElement.h
@ -77,7 +77,7 @@ private:

    Function<void()> m_script_ready_callback;

-    RefPtr<Script> m_script;
+    JS::GCPtr<Script> m_script;

    Optional<DOM::DocumentLoadEventDelayer> m_document_load_event_delayer;