LibJS: Let isNaN() with no argument return true, add tests

Author: https://github.com/linusg
Commit: https://github.com/SerenityOS/serenity/commit/8ff2881b1a1
Pull-request: https://github.com/SerenityOS/serenity/pull/1923

Libraries/LibJS/Runtime/GlobalObject.cpp

@@ -137,9 +137,8 @@ Value GlobalObject::gc(Interpreter& interpreter)
 
 Value GlobalObject::is_nan(Interpreter& interpreter)
 {
-    if (interpreter.argument_count() < 1)
-        return js_undefined();
-    return Value(interpreter.argument(0).to_number().is_nan());
+    auto value = interpreter.argument(0).to_number();
+    return Value(value.is_nan());
 }
 
 }

Libraries/LibJS/Tests/isNaN.js

@@ -0,0 +1,28 @@
+load("test-common.js");
+
+try {
+    assert(isNaN.length === 1);
+
+    assert(isNaN(0) === false);
+    assert(isNaN(42) === false);
+    assert(isNaN("") === false);
+    assert(isNaN("0") === false);
+    assert(isNaN("42") === false);
+    assert(isNaN(true) === false);
+    assert(isNaN(false) === false);
+    assert(isNaN(null) === false);
+    assert(isNaN([]) === false);
+    assert(isNaN(Infinity) === false);
+    assert(isNaN(-Infinity) === false);
+
+    assert(isNaN() === true);
+    assert(isNaN(NaN) === true);
+    assert(isNaN(undefined) === true);
+    assert(isNaN("foo") === true);
+    assert(isNaN({}) === true);
+    assert(isNaN([1, 2, 3]) === true);
+
+    console.log("PASS");
+} catch (e) {
+    console.log("FAIL: " + e.message);
+}