mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-29 12:19:54 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibURL: Make URL::serialized_host() infallible

Browse source 
This can no longer fail, so update the return type to match.

This makes a few more methods now unable to return errors, but one thing
at a time. 😅
This commit is contained in:
Sam Atkins 2024-11-28 14:32:07 +00:00 • committed by Andreas Kling
commit 900c131178
Notes: github-actions[bot] 2024-11-30 11:23:28 +00:00
13 changed files with 47 additions and 51 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Libraries/LibWeb/HTML/HTMLHyperlinkElementUtils.cpp
View file

@ -172,10 +172,10 @@ String HTMLHyperlinkElementUtils::host() const
// 4. If url's port is null, return url's host, serialized.
if (!url->port().has_value())
return MUST(url->serialized_host());
return url->serialized_host();
// 5. Return url's host, serialized, followed by ":" and url's port, serialized.
return MUST(String::formatted("{}:{}", MUST(url->serialized_host()), url->port().value()));
return MUST(String::formatted("{}:{}", url->serialized_host(), url->port().value()));
}
// https://html.spec.whatwg.org/multipage/links.html#dom-hyperlink-host
@ -211,7 +211,7 @@ String HTMLHyperlinkElementUtils::hostname() const
return String {};
// 4. Return url's host, serialized.
return MUST(url.serialized_host());
return url.serialized_host();
}
void HTMLHyperlinkElementUtils::set_hostname(StringView hostname)