mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-06-02 16:33:13 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 12

LibWeb: Schedule HTML::EventLoop processing when there are queued tasks

Browse source 
Since we can't simply give HTML::EventLoop control of the whole program,
we have to integrate with Core::EventLoop.

We do this by having a single-shot 0ms Core::Timer that we start when
a task is added to the queue, and restart after processing the queue and
there are still tasks in the queue.
This commit is contained in:
Andreas Kling 2021-09-09 00:38:43 +02:00
parent e0c7f8dafa
commit 909e522cf7
Notes: sideshowbarker 2024-07-18 04:24:27 +09:00
5 changed files with 35 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

21
Userland/Libraries/LibWeb/HTML/EventLoop/EventLoop.cpp
View file

@ -4,6 +4,7 @@
* SPDX-License-Identifier: BSD-2-Clause
*/
#include <LibCore/Timer.h>
#include <LibJS/Runtime/VM.h>
#include <LibWeb/Bindings/MainThreadVM.h>
#include <LibWeb/HTML/EventLoop/EventLoop.h>
@ -11,6 +12,7 @@
namespace Web::HTML {
EventLoop::EventLoop()
: m_task_queue(*this)
{
}
@ -18,6 +20,18 @@ EventLoop::~EventLoop()
{
}
void EventLoop::schedule()
{
if (!m_system_event_loop_timer) {
m_system_event_loop_timer = Core::Timer::create_single_shot(0, [this] {
process();
});
}
if (!m_system_event_loop_timer->is_active())
m_system_event_loop_timer->restart();
}
void EventLoop::set_vm(JS::VM& vm)
{
VERIFY(!m_vm);
@ -66,6 +80,9 @@ void EventLoop::process()
// 2. Let oldestTask be the first runnable task in taskQueue, and remove it from taskQueue.
auto oldest_task = task_queue.take_first_runnable();
// FIXME: Figure out if we need to be here when there's no task.
VERIFY(oldest_task);
// 3. Set the event loop's currently running task to oldestTask.
m_currently_running_task = oldest_task.ptr();
@ -145,6 +162,10 @@ void EventLoop::process()
// FIXME: 3. Update the rendering of that dedicated worker to reflect the current state.
// FIXME: 2. If there are no tasks in the event loop's task queues and the WorkerGlobalScope object's closing flag is true, then destroy the event loop, aborting these steps, resuming the run a worker steps described in the Web workers section below.
// If there are tasks in the queue, schedule a new round of processing. :^)
if (!m_task_queue.is_empty())
schedule();
}
}