mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-08-01 13:49:16 +00:00
LibURL: Replace Host's Empty state with making Url's Host optional
A couple of reasons: - Origin's Host (when in the tuple state) can't be null - There's an "empty host" concept in the spec which is NOT the same as a null Host, and that was confusing me.
This commit is contained in:
parent
8b984c0c57
commit
90e763de4c
Notes:
github-actions[bot]
2024-11-30 11:24:09 +00:00
Author: https://github.com/AtkinsSJ
Commit: 90e763de4c
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/2610
Reviewed-by: https://github.com/shannonbooth ✅
17 changed files with 44 additions and 42 deletions
|
@ -284,7 +284,7 @@ WebIDL::ExceptionOr<String> DOMURL::host() const
|
|||
auto& url = m_url;
|
||||
|
||||
// 2. If url’s host is null, then return the empty string.
|
||||
if (url.host().has<Empty>())
|
||||
if (!url.host().has_value())
|
||||
return String {};
|
||||
|
||||
// 3. If url’s port is null, return url’s host, serialized.
|
||||
|
@ -312,7 +312,7 @@ WebIDL::ExceptionOr<String> DOMURL::hostname() const
|
|||
auto& vm = realm().vm();
|
||||
|
||||
// 1. If this’s URL’s host is null, then return the empty string.
|
||||
if (m_url.host().has<Empty>())
|
||||
if (!m_url.host().has_value())
|
||||
return String {};
|
||||
|
||||
// 2. Return this’s URL’s host, serialized.
|
||||
|
@ -477,6 +477,7 @@ void DOMURL::set_hash(String const& hash)
|
|||
}
|
||||
|
||||
// https://url.spec.whatwg.org/#concept-domain
|
||||
// FIXME: Move into URL::Host
|
||||
bool host_is_domain(URL::Host const& host)
|
||||
{
|
||||
// A domain is a non-empty ASCII string that identifies a realm within a network.
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue