mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-01 05:39:11 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibURL: Replace Host's Empty state with making Url's Host optional

Browse source 
A couple of reasons:
- Origin's Host (when in the tuple state) can't be null
- There's an "empty host" concept in the spec which is NOT the same as a
  null Host, and that was confusing me.
This commit is contained in:
Sam Atkins 2024-11-27 12:48:28 +00:00 • committed by Andreas Kling
commit 90e763de4c
Notes: github-actions[bot] 2024-11-30 11:24:09 +00:00
17 changed files with 44 additions and 42 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Libraries/LibWeb/HTML/HTMLHyperlinkElementUtils.cpp
View file

@ -167,7 +167,7 @@ String HTMLHyperlinkElementUtils::host() const
auto const& url = m_url;
// 3. If url or url's host is null, return the empty string.
if (!url.has_value() || url->host().has<Empty>())
if (!url.has_value() || !url->host().has_value())
return String {};
// 4. If url's port is null, return url's host, serialized.
@ -206,7 +206,8 @@ String HTMLHyperlinkElementUtils::hostname() const
URL::URL url(href());
// 3. If url or url's host is null, return the empty string.
if (url.host().has<Empty>())
// FIXME: How can url be null here?
if (!url.host().has_value())
return String {};
// 4. Return url's host, serialized.