mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-03 06:40:05 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibURL: Replace Host's Empty state with making Url's Host optional

Browse source 
A couple of reasons:
- Origin's Host (when in the tuple state) can't be null
- There's an "empty host" concept in the spec which is NOT the same as a
  null Host, and that was confusing me.
This commit is contained in:
Sam Atkins 2024-11-27 12:48:28 +00:00 • committed by Andreas Kling
commit 90e763de4c
Notes: github-actions[bot] 2024-11-30 11:24:09 +00:00
17 changed files with 44 additions and 42 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Libraries/LibWeb/HTML/WorkerLocation.cpp
View file

@ -46,7 +46,7 @@ WebIDL::ExceptionOr<String> WorkerLocation::host() const
auto const& url = m_global_scope->url();
// 2. If url's host is null, return the empty string.
if (url.host().has<Empty>())
if (!url.host().has_value())
return String {};
// 3. If url's port is null, return url's host, serialized.
@ -67,11 +67,11 @@ WebIDL::ExceptionOr<String> WorkerLocation::hostname() const
auto const& host = m_global_scope->url().host();
// 2. If host is null, return the empty string.
if (host.has<Empty>())
if (!host.has_value())
return String {};
// 3. Return host, serialized.
return TRY_OR_THROW_OOM(vm, URL::Parser::serialize_host(host));
return TRY_OR_THROW_OOM(vm, URL::Parser::serialize_host(host.value()));
}
// https://html.spec.whatwg.org/multipage/workers.html#dom-workerlocation-port