mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-31 21:29:06 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Ensure principal realm returned for nested Shadow Realms

Browse source 
Recently reported against the shadow realm proposal after running into
issues with WPT tests.

In a nested shadow realm, the associated realm is a shadow realm, not
the principal realm. One such issue this fixes is a crash when a nested
shadow realm performs an operation which requires the principal settings
object.
This commit is contained in:
Shannon Booth 2024-11-28 05:10:30 +13:00 • committed by Andreas Kling
commit 91007eb476
Notes: github-actions[bot] 2024-11-30 11:07:04 +00:00
3 changed files with 44 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibWeb/Bindings/MainThreadVM.cpp
View file

@ -580,8 +580,8 @@ ErrorOr<void> initialize_main_thread_vm(HTML::EventLoop::Type type)
// 4. Set settings's execution context to context.
.execution_context = move(context),
// 5. Set settings's principal realm to O's associated realm
.principal_realm = object.shape().realm(),
// 5. Set settings's principal realm to O's associated realm's principal realm
.principal_realm = HTML::principal_realm(object.shape().realm()),
// 6. Set settings's module map to a new module map, initially empty.
.module_map = realm.create<HTML::ModuleMap>(),

1
Tests/LibWeb/Text/expected/HTML/ShadowRealm-in-ShadowRealm-evaluate-DOM-Event.txt Normal file
View file

@ -0,0 +1 @@
Some event...

41
Tests/LibWeb/Text/input/HTML/ShadowRealm-in-ShadowRealm-evaluate-DOM-Event.html Normal file
View file

@ -0,0 +1,41 @@
<script src="../include.js"></script>
<script>
function shadowRealmEvalAsync(realm, asyncBody) {
return new Promise(realm.evaluate(`
(resolve, reject) => {
(async () => {
${asyncBody}
})().then(resolve, (e) => reject(e.toString()));
}
`));
};
asyncTest(async done => {
const outerShadowRealm = new ShadowRealm();
outerShadowRealm.evaluate(`
var innerShadowRealm = new ShadowRealm();
`);
const outerResult = await shadowRealmEvalAsync(outerShadowRealm, `
function shadowRealmEvalAsync(realm, asyncBody) {
return new Promise(realm.evaluate(\`
(resolve, reject) => {
(async () => {
\${asyncBody}
})().then(resolve, (e) => reject(e.toString()));
}
\`));
};
const innerResult = await shadowRealmEvalAsync(innerShadowRealm, \`
return new Event("Some event...").type;
\`);
return innerResult;
`);
println(outerResult);
done();
});
</script>