mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-28 11:49:44 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 10

LibWeb: Allow <svg> to establish a stacking context

Browse source 
83b6bc4 went too far by forbidding SVGSVGElement from establishing a
stacking context. This element type does follow the behavior of CSS
boxes, unlike inner SVG elements like `<rect>`, `<circle>`, etc., which
are not supposed to be aware of concepts like stacking contexts,
overflow clipping, scroll offsets, etc.

This change allows us to delete overrides of `before_paint()` and
`after_paint()` in SVGPaintable and SVGSVGPaintable, because display
list recording code has been rearranged to take care of clipping and
scrolling before recursing into SVGSVGPaintable descendants.

`Screenshot/images/css-transform-box-ref.png` expectation is updated and
fixes a bug where a rectangle at the very bottom of the page was not
clipped correctly.
`Screenshot/images/svg-filters-lb-website-ref.png` has a more subtle
difference, but if you look closely, you’ll see it matches other
browsers more closely now.
This commit is contained in:
Aliaksandr Kalenik 2025-07-12 00:17:38 +02:00 • committed by Jelle Raaijmakers
commit 910fd426a2
Notes: github-actions[bot] 2025-07-12 09:02:17 +00:00
10 changed files with 87 additions and 60 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibWeb/Layout/Node.cpp
View file

@ -174,7 +174,7 @@ bool Node::establishes_stacking_context() const
if (!has_style())
return false;
if (is_svg_box() || is_svg_svg_box())
if (is_svg_box())
return false;
// We make a stacking context for the viewport. Painting and hit testing starts from here.