mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-31 05:09:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

AK: Add workaround for faulty Sanitizer warning on gcc 13+ in Atomic

Browse source 
gcc can't seem to figure out that the address of a member variable of
AK::Atomic<u32> in AtomicRefCounted cannot be null when fetch_sub-ing.
Add a bogus condition to convince the compiler that it can't be null.
This commit is contained in:
Andrew Kaster 2024-04-22 20:17:37 -06:00 • committed by Andrew Kaster
commit 913cffe928
Notes: sideshowbarker 2024-07-17 08:42:05 +09:00
1 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

8
AK/Atomic.h
View file

@ -279,7 +279,13 @@ public:
ALWAYS_INLINE T fetch_sub(T val, MemoryOrder order = DefaultMemoryOrder) volatile noexcept
{
return __atomic_fetch_sub(&m_value, val, order);
T volatile* ptr = &m_value;
// FIXME: GCC > 12 will wrongly warn on -Wstringop-overflow here with ASAN+UBSAN
#if defined(AK_COMPILER_GCC) && defined(HAS_ADDRESS_SANITIZER)
if (!ptr)
__builtin_unreachable();
#endif
return __atomic_fetch_sub(ptr, val, order);
}
ALWAYS_INLINE T operator&=(T val) volatile noexcept