From 917d659f8bf5f063ba7e80e93571b8dcd93be97b Mon Sep 17 00:00:00 2001 From: Sam Atkins Date: Thu, 28 Nov 2024 16:26:57 +0000 Subject: [PATCH] LibWeb/CSS: Remove unwanted newline from list serialization Gets us 1 subtest pass. --- Libraries/LibWeb/CSS/Serialize.h | 5 ++++- .../Text/expected/wpt-import/css/cssom/serialize-values.txt | 6 +++--- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/Libraries/LibWeb/CSS/Serialize.h b/Libraries/LibWeb/CSS/Serialize.h index 7850004cfaa..58c9052ac59 100644 --- a/Libraries/LibWeb/CSS/Serialize.h +++ b/Libraries/LibWeb/CSS/Serialize.h @@ -31,14 +31,17 @@ String serialize_a_string(StringView string); String serialize_a_url(StringView url); String serialize_a_srgb_value(Color color); +// https://www.w3.org/TR/cssom/#serialize-a-comma-separated-list template void serialize_a_comma_separated_list(StringBuilder& builder, Vector const& items, SerializeItem serialize_item) { + // To serialize a comma-separated list concatenate all items of the list in list order + // while separating them by ", ", i.e., COMMA (U+002C) followed by a single SPACE (U+0020). for (size_t i = 0; i < items.size(); i++) { auto& item = items.at(i); serialize_item(builder, item); if ((i + 1) < items.size()) { - builder.append(",\n"sv); + builder.append(", "sv); } } } diff --git a/Tests/LibWeb/Text/expected/wpt-import/css/cssom/serialize-values.txt b/Tests/LibWeb/Text/expected/wpt-import/css/cssom/serialize-values.txt index e44c2e46ff2..6078de42ebd 100644 --- a/Tests/LibWeb/Text/expected/wpt-import/css/cssom/serialize-values.txt +++ b/Tests/LibWeb/Text/expected/wpt-import/css/cssom/serialize-values.txt @@ -6,8 +6,8 @@ Rerun Found 687 tests -463 Pass -224 Fail +464 Pass +223 Fail Details Result Test Name MessagePass background-attachment: scroll Pass background-attachment: fixed @@ -331,7 +331,7 @@ Fail content: url("http://localhost/") Fail content: url(http://localhost/) Fail content: counter(par-num) Fail content: counter(par-num, decimal) -Fail content: counter(par-num, upper-roman) +Pass content: counter(par-num, upper-roman) Pass content: attr(foo-bar) Pass content: attr(foo_bar) Fail content: attr(|bar)