mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-09-23 01:38:56 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibCrypto: Store ASN1 certificate timestamps as UnixDateTime

Browse source 
We are currently using Core::DateTime, which is meant to represent local
time. However, we are doing no conversion between the parsed time in UTC
and local time, so we end up comparing time stamps from different time
zones.

Instead, store the parsed times as UnixDateTime, which is UTC. Then we
can always compare the parsed times against the current UTC time.

This also lets us store parsed milliseconds.
This commit is contained in:
Timothy Flynn 2024-03-07 10:34:45 -05:00 • committed by Ali Mohammad Pur
commit 928287b782
Notes: sideshowbarker 2024-07-17 06:51:48 +09:00
7 changed files with 64 additions and 65 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibTLS/Certificate.cpp
View file

@ -296,7 +296,7 @@ static ErrorOr<RelativeDistinguishedName> parse_name(Crypto::ASN1::Decoder& deco
return rdn;
}
static ErrorOr<Core::DateTime> parse_time(Crypto::ASN1::Decoder& decoder, Vector<StringView> current_scope)
static ErrorOr<UnixDateTime> parse_time(Crypto::ASN1::Decoder& decoder, Vector<StringView> current_scope)
{
// Time ::= Choice {
// utc_time UTCTime,