mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-08 09:09:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Store IndexedDB Databases mappings properly

Browse source
This commit is contained in:
stelar7 2024-11-07 22:20:38 +01:00 • committed by Jelle Raaijmakers
commit 932fb2024e
Notes: github-actions[bot] 2024-11-26 13:51:43 +00:00
2 changed files with 12 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Libraries/LibWeb/IndexedDB/Internal/Algorithms.cpp
View file

@ -40,8 +40,11 @@ WebIDL::ExceptionOr<GC::Ref<IDBDatabase>> open_a_database_connection(JS::Realm&
})); }));
// 4. Let db be the database named name in storageKey, or null otherwise. // 4. Let db be the database named name in storageKey, or null otherwise.
auto maybe_db = Database::for_key_and_name(storage_key, name);
GC::Ptr<Database> db; GC::Ptr<Database> db;
auto maybe_db = Database::for_key_and_name(storage_key, name);
if (maybe_db.has_value()) {
db = maybe_db.value();
}
// 5. If version is undefined, let version be 1 if db is null, or db’s version otherwise. // 5. If version is undefined, let version be 1 if db is null, or db’s version otherwise.
auto version = maybe_version.value_or(maybe_db.has_value() ? maybe_db.value()->version() : 1); auto version = maybe_version.value_or(maybe_db.has_value() ? maybe_db.value()->version() : 1);

11
Libraries/LibWeb/IndexedDB/Internal/Database.cpp
View file

@ -52,9 +52,12 @@ ErrorOr<GC::Root<Database>> Database::create_for_key_and_name(JS::Realm& realm,
return HashMap<String, GC::Root<Database>>(); return HashMap<String, GC::Root<Database>>();
})); }));
return database_mapping.try_ensure(name, [&] { auto value = Database::create(realm, name);
return Database::create(realm, name);
}); database_mapping.set(name, value);
m_databases.set(key, database_mapping);
return value;
} }
ErrorOr<void> Database::delete_for_key_and_name(StorageAPI::StorageKey& key, String& name) ErrorOr<void> Database::delete_for_key_and_name(StorageAPI::StorageKey& key, String& name)
@ -73,6 +76,8 @@ ErrorOr<void> Database::delete_for_key_and_name(StorageAPI::StorageKey& key, Str
if (!did_remove) if (!did_remove)
return {}; return {};
m_databases.set(key, database_mapping);
return {}; return {};
} }