mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-09 01:29:17 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb/SVG: Don't crash when changing SVG image href

Browse source 
Previously, a segfault could occur if `m_resource_request` was replaced
before its callbacks were invoked.
This commit is contained in:
Tim Ledbetter 2025-07-10 22:48:12 +01:00 • committed by Jelle Raaijmakers
commit 93a35895ae
Notes: github-actions[bot] 2025-07-12 11:15:02 +00:00
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibWeb/SVG/SVGImageElement.cpp
View file

@ -159,9 +159,9 @@ void SVGImageElement::fetch_the_document(URL::URL const& url)
m_load_event_delayer.emplace(document()); m_load_event_delayer.emplace(document());
m_resource_request = HTML::SharedResourceRequest::get_or_create(realm(), document().page(), url); m_resource_request = HTML::SharedResourceRequest::get_or_create(realm(), document().page(), url);
m_resource_request->add_callbacks( m_resource_request->add_callbacks(
[this] { [this, resource_request = GC::Root { m_resource_request }] {
m_load_event_delayer.clear(); m_load_event_delayer.clear();
auto image_data = m_resource_request->image_data(); auto image_data = resource_request->image_data();
if (image_data->is_animated() && image_data->frame_count() > 1) { if (image_data->is_animated() && image_data->frame_count() > 1) {
m_current_frame_index = 0; m_current_frame_index = 0;
m_animation_timer->set_interval(image_data->frame_duration(0)); m_animation_timer->set_interval(image_data->frame_duration(0));