mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-06-03 00:42:54 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 12

LibWeb: Abstract common operations of graphical SVG elements

Browse source
This commit is contained in:
Matthew Olsson 2020-07-22 15:17:39 -07:00 • committed by Andreas Kling
parent 3206263c2d
commit 943e4f8bf1
Notes: sideshowbarker 2024-07-19 04:36:54 +09:00
5 changed files with 83 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

13
Libraries/LibWeb/DOM/HTMLPathElement.cpp
View file

@ -417,6 +417,8 @@ static void print_instruction(const PathInstruction& instruction)
void HTMLPathElement::parse_attribute(const FlyString& name, const String& value)
{
HTMLElement::parse_attribute(name, value);
SvgGraphicElement::parse_attribute(name, value);
if (name == "d")
m_instructions = PathDataParser(value).parse();
}
@ -586,11 +588,16 @@ void HTMLPathElement::paint(const SvgPaintingContext& context, Gfx::Painter& pai
}
}
painter.stroke_path(path, context.stroke_color, context.stroke_width);
// We need to fill the path before applying the stroke, however the filled
// path must be closed, whereas the stroke path may not necessary be closed.
// Copy the path and close it for filling, but use the previous path for stroke
auto closed_path = path;
closed_path.close();
// Fills are computed as though all paths are closed (https://svgwg.org/svg2-draft/painting.html#FillProperties)
path.close();
painter.fill_path(path, context.fill_color, Gfx::Painter::WindingRule::EvenOdd);
painter.fill_path(closed_path, fill_color(context), Gfx::Painter::WindingRule::EvenOdd);
painter.stroke_path(path, stroke_color(context), stroke_width(context));
}
}