mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-09-21 08:48:57 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

LibUnicode: Generate and use code point composition mappings

Browse source 
These allow us to binary search the code point compositions based on
the first code point being combined, which makes the search close to
O(log N) instead of O(N).
This commit is contained in:
Idan Horowitz 2024-04-06 18:45:52 +03:00 • committed by Tim Flynn
commit 945c58c7c1
Notes: sideshowbarker 2024-07-17 02:39:10 +09:00
3 changed files with 80 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

19
Userland/Libraries/LibUnicode/Normalize.cpp
View file

@ -20,7 +20,7 @@ struct Unicode::CodePointDecomposition { };
namespace Unicode {
Optional<CodePointDecomposition const> __attribute__((weak)) code_point_decomposition(u32) { return {}; }
Optional<CodePointDecomposition const> __attribute__((weak)) code_point_decomposition_by_index(size_t) { return {}; }
Optional<u32> __attribute__((weak)) code_point_composition(u32, u32) { return {}; }
NormalizationForm normalization_form_from_string(StringView form)
{
@ -126,20 +126,9 @@ static u32 combine_hangul_code_points(u32 a, u32 b)
static u32 combine_code_points([[maybe_unused]] u32 a, [[maybe_unused]] u32 b)
{
#if ENABLE_UNICODE_DATA
Array<u32, 2> const points { a, b };
// FIXME: Do something better than linear search to find reverse mappings.
for (size_t index = 0;; ++index) {
auto mapping_maybe = Unicode::code_point_decomposition_by_index(index);
if (!mapping_maybe.has_value())
break;
auto& mapping = mapping_maybe.value();
if (mapping.tag == CompatibilityFormattingTag::Canonical && mapping.decomposition == points) {
if (code_point_has_property(mapping.code_point, Property::Full_Composition_Exclusion))
continue;
return mapping.code_point;
}
}
auto composition = code_point_composition(a, b);
if (composition.has_value())
return composition.value();
#endif
return 0;

2
Userland/Libraries/LibUnicode/Normalize.h
View file

@ -17,7 +17,7 @@
namespace Unicode {
Optional<CodePointDecomposition const> code_point_decomposition(u32 code_point);
Optional<CodePointDecomposition const> code_point_decomposition_by_index(size_t index);
Optional<u32> code_point_composition(u32 first_code_point, u32 second_code_point);
enum class NormalizationForm {
NFD,