mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-02 14:19:48 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Ignore boxes wholly in the negative scrollable overflow region

Browse source 
This fixes an issue where https://hey.com/ was horizontally scrollable
even though it shouldn't be.
This commit is contained in:
Andreas Kling 2024-10-08 13:00:27 +02:00 • committed by Andreas Kling
commit 94721385ce
Notes: github-actions[bot] 2024-10-08 12:34:26 +00:00
3 changed files with 23 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Tests/LibWeb/Layout/expected/actually-ignore-the-negative-overflow-region.txt Normal file
View file

@ -0,0 +1,9 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x16 [BFC] children: not-inline
Box <body> at (8,8) content-size 784x0 flex-container(row) [FFC] children: not-inline
BlockContainer <div> at (-5000,8) content-size 0x0 positioned [BFC] children: not-inline
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x16]
PaintableBox (Box<BODY>) [8,8 784x0]
PaintableWithLines (BlockContainer<DIV>) [-5000,8 0x0]

8
Tests/LibWeb/Layout/input/actually-ignore-the-negative-overflow-region.html Normal file
View file

@ -0,0 +1,8 @@
<!doctype html><style>
* { outline: 1px solid black; }
body { display: flex; }
div {
position: absolute;
left: -5000px;
}
</style><body><div>

10
Userland/Libraries/LibWeb/Layout/LayoutState.cpp
View file

@ -105,11 +105,13 @@ static CSSPixelRect measure_scrollable_overflow(Box const& box)
return IterationDecision::Continue; return IterationDecision::Continue;
auto child_border_box = child.paintable_box()->absolute_border_box_rect(); auto child_border_box = child.paintable_box()->absolute_border_box_rect();
// NOTE: Here we check that the child is not wholly in the negative scrollable overflow region. // NOTE: Here we check that the child is not wholly in the negative scrollable overflow region.
if (child_border_box.bottom() > 0 && child_border_box.right() > 0) { if (child_border_box.bottom() < 0 || child_border_box.right() < 0)
scrollable_overflow_rect = scrollable_overflow_rect.united(child_border_box); return IterationDecision::Continue;
content_overflow_rect = content_overflow_rect.united(child_border_box);
} scrollable_overflow_rect = scrollable_overflow_rect.united(child_border_box);
content_overflow_rect = content_overflow_rect.united(child_border_box);
// - The scrollable overflow areas of all of the above boxes // - The scrollable overflow areas of all of the above boxes
// (including zero-area boxes and accounting for transforms as described above), // (including zero-area boxes and accounting for transforms as described above),