mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-27 12:46:06 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 12

Revert "WebContent: Restore ability to use Inspector accessors like $0"

Browse source 
This reverts commit ae1c58fad1.
This commit is contained in:
Timothy Flynn 2024-10-31 08:03:32 -04:00 • committed by Tim Flynn
commit 94a0f36b3e
Notes: github-actions[bot] 2024-11-06 13:43:23 +00:00
1 changed files with 12 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

25
Userland/Services/WebContent/WebContentConsoleClient.cpp
View file

@ -11,10 +11,13 @@
#include <AK/StringBuilder.h>
#include <LibJS/MarkupGenerator.h>
#include <LibJS/Print.h>
#include <LibJS/Runtime/GlobalEnvironment.h>
#include <LibJS/Runtime/ObjectEnvironment.h>
#include <LibJS/Runtime/Realm.h>
#include <LibJS/Runtime/VM.h>
#include <LibWeb/HTML/Scripting/ClassicScript.h>
#include <LibWeb/HTML/Scripting/Environments.h>
#include <LibWeb/HTML/Window.h>
#include <LibWeb/WebDriver/ExecuteScript.h>
#include <WebContent/ConsoleGlobalEnvironmentExtensions.h>
#include <WebContent/PageClient.h>
#include <WebContent/WebContentConsoleClient.h>
@ -45,21 +48,17 @@ void WebContentConsoleClient::handle_input(ByteString const& js_source)
if (!m_console_global_environment_extensions)
return;
auto& realm = m_console->realm();
auto& window = verify_cast<Web::HTML::Window>(realm.global_object());
auto& settings = Web::HTML::relevant_settings_object(*m_console_global_environment_extensions);
auto script = Web::HTML::ClassicScript::create("(console)", js_source, settings.realm(), settings.api_base_url());
auto source_text = ByteString::formatted("return {}", js_source);
auto with_scope = JS::new_object_environment(*m_console_global_environment_extensions, true, &settings.realm().global_environment());
auto completion = Web::WebDriver::execute_a_function_body(window, source_text, {}, m_console_global_environment_extensions);
// FIXME: Add parse error printouts back once ClassicScript can report parse errors.
auto result = script->run(Web::HTML::ClassicScript::RethrowErrors::No, with_scope);
if (completion.has_value()) {
m_console_global_environment_extensions->set_most_recent_result(completion.value());
print_html(JS::MarkupGenerator::html_from_value(completion.value()).release_value_but_fixme_should_propagate_errors().to_byte_string());
} else {
m_console_global_environment_extensions->set_most_recent_result(JS::js_undefined());
if (completion.error().value().has_value())
print_html(JS::MarkupGenerator::html_from_value(completion.error().value().value()).release_value_but_fixme_should_propagate_errors().to_byte_string());
if (result.value().has_value()) {
m_console_global_environment_extensions->set_most_recent_result(result.value().value());
print_html(JS::MarkupGenerator::html_from_value(*result.value()).release_value_but_fixme_should_propagate_errors().to_byte_string());
}
}