mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-29 12:19:54 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Make sure style is up-to-date in getAnimations()

Browse source 
StyleComputer is responsible for assigning animation targets, so we
have to make sure there are no pending style updates before querying
animations of an element.

This change also introduces a version of getAnimations() that does not
check style updates and used by StyleComputer to avoid mutual recursion.
This commit is contained in:
Aliaksandr Kalenik 2024-10-02 05:53:03 +02:00 • committed by Sam Atkins
commit 94b3b84dd8
Notes: github-actions[bot] 2024-10-02 15:29:35 +00:00
5 changed files with 35 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/CSS/StyleComputer.cpp
View file

@ -1563,7 +1563,7 @@ void StyleComputer::compute_cascaded_values(StyleProperties& style, DOM::Element
}
}
auto animations = element.get_animations({ .subtree = false });
auto animations = element.get_animations_internal({ .subtree = false });
for (auto& animation : animations) {
if (auto effect = animation->effect(); effect && effect->is_keyframe_effect()) {
auto& keyframe_effect = *static_cast<Animations::KeyframeEffect*>(effect.ptr());