mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-09-29 20:59:00 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Fix nodesToRemove collecting traversal in Range::delete_contents

Browse source 
With this change children are no longer skipped in tree traversal when
start node of range equals to end node of range.

Fixes https://github.com/SerenityOS/serenity/issues/24036
This commit is contained in:
Aliaksandr Kalenik 2024-04-20 12:50:14 +02:00 • committed by Andreas Kling
commit 9540af6489
Notes: sideshowbarker 2024-07-17 18:38:54 +09:00
3 changed files with 19 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Tests/LibWeb/Text/expected/DOM/Range-deleteContents.txt Normal file
View file

@ -0,0 +1 @@
before after

17
Tests/LibWeb/Text/input/DOM/Range-deleteContents.html Normal file
View file

@ -0,0 +1,17 @@
<!DOCTYPE html>
before
<div id="for-deletion">
<div>should</div>
<div>be</div>
<div>gone</div>
</div>
after
<script src="../include.js"></script>
<script>
test(() => {
const element = document.getElementById("for-deletion");
const range = document.createRange();
range.selectNodeContents(element);
range.deleteContents();
});
</script>

2
Userland/Libraries/LibWeb/DOM/Range.cpp
View file

@ -1118,7 +1118,7 @@ WebIDL::ExceptionOr<void> Range::delete_contents()
// 4. Let nodes to remove be a list of all the nodes that are contained in this, in tree order, omitting any node whose parent is also contained in this. // 4. Let nodes to remove be a list of all the nodes that are contained in this, in tree order, omitting any node whose parent is also contained in this.
JS::MarkedVector<Node*> nodes_to_remove(heap()); JS::MarkedVector<Node*> nodes_to_remove(heap());
for (Node const* node = start_container(); node != end_container()->next_in_pre_order(); node = node->next_in_pre_order()) { for (Node const* node = start_container(); node != end_container()->next_sibling(); node = node->next_in_pre_order()) {
if (contains_node(*node) && (!node->parent_node() || !contains_node(*node->parent_node()))) if (contains_node(*node) && (!node->parent_node() || !contains_node(*node->parent_node())))
nodes_to_remove.append(const_cast<Node*>(node)); nodes_to_remove.append(const_cast<Node*>(node));
} }