mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-31 05:09:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

Kernel: Make sys$posix_fallocate() fail with ENODEV on non-regular files

Browse source 
Previously we tried to determine if `fd` refers to a non-regular file by
doing a stat() operation on the file.

This didn't work out very well since many File subclasses don't
actually implement stat() but instead fall back to failing with EBADF.

This patch fixes the issue by checking for regular files with
File::is_regular_file() instead.
This commit is contained in:
Andreas Kling 2022-11-27 20:09:17 +01:00
commit 961e1e590b
Notes: sideshowbarker 2024-07-17 03:58:03 +09:00
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Kernel/Syscalls/fallocate.cpp
View file

@ -37,7 +37,8 @@ ErrorOr<FlatPtr> Process::sys$posix_fallocate(int fd, Userspace<off_t const*> us
if (description->is_fifo())
return ESPIPE;
if (!S_ISREG(TRY(description->file().stat()).st_mode))
// [ENODEV] The fd argument does not refer to a regular file.
if (!description->file().is_regular_file())
return ENODEV;
VERIFY(description->file().is_inode());