mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-07-29 04:09:13 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Assign static position for abspos boxes nested into TFC

Browse source 
TFC is not aware of how to correctly calculate a static position for
abspos boxes, but assigning (0, 0) is better than crashing during abspos
item layout.

Fixes https://github.com/LadybirdBrowser/ladybird/issues/1382
This commit is contained in:
Aliaksandr Kalenik 2024-09-13 22:42:43 +02:00 • committed by Andreas Kling
commit 9621439db0
Notes: github-actions[bot] 2024-09-14 13:04:58 +00:00
5 changed files with 70 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

29
Userland/Libraries/LibWeb/Layout/TableFormattingContext.cpp
View file

@ -1607,6 +1607,35 @@ void TableFormattingContext::run_until_width_calculation(AvailableSpace const& a
compute_table_width();
}
void TableFormattingContext::parent_context_did_dimension_child_root_box()
{
if (m_layout_mode != LayoutMode::Normal)
return;
context_box().for_each_in_subtree_of_type<Box const>([&](Layout::Box const& box) {
if (box.is_absolutely_positioned()) {
// FIXME: calculate_static_position_rect() is not aware of how to correctly calculate static position for
// a box nested inside a table, but we need to set some value, so layout_absolutely_positioned_element()
// won't crash trying to access it.
m_state.get_mutable(box).set_static_position_rect(calculate_static_position_rect(box));
}
if (formatting_context_type_created_by_box(box).has_value()) {
return TraversalDecision::SkipChildrenAndContinue;
}
return TraversalDecision::Continue;
});
for (auto& child : context_box().contained_abspos_children()) {
auto& box = verify_cast<Box>(*child);
auto& cb_state = m_state.get(*box.containing_block());
auto available_width = AvailableSize::make_definite(cb_state.content_width() + cb_state.padding_left + cb_state.padding_right);
auto available_height = AvailableSize::make_definite(cb_state.content_height() + cb_state.padding_top + cb_state.padding_bottom);
layout_absolutely_positioned_element(box, AvailableSpace(available_width, available_height));
}
}
void TableFormattingContext::run(AvailableSpace const& available_space)
{
m_available_space = available_space;