mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-22 02:09:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibJS: Implement the ECMA-402 Instant.prototype.toLocaleString.js

Browse source
This commit is contained in:
Timothy Flynn 2024-11-27 16:13:47 -05:00 • committed by Andreas Kling
commit 964f41bb53
Notes: github-actions[bot] 2024-11-29 08:53:41 +00:00
2 changed files with 14 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

16
Libraries/LibJS/Runtime/Temporal/InstantPrototype.cpp
View file

@ -6,6 +6,8 @@
*/ */
#include <LibJS/Runtime/Date.h> #include <LibJS/Runtime/Date.h>
#include <LibJS/Runtime/Intl/DateTimeFormat.h>
#include <LibJS/Runtime/Intl/DateTimeFormatConstructor.h>
#include <LibJS/Runtime/Temporal/AbstractOperations.h> #include <LibJS/Runtime/Temporal/AbstractOperations.h>
#include <LibJS/Runtime/Temporal/Duration.h> #include <LibJS/Runtime/Temporal/Duration.h>
#include <LibJS/Runtime/Temporal/InstantPrototype.h> #include <LibJS/Runtime/Temporal/InstantPrototype.h>
@ -294,15 +296,23 @@ JS_DEFINE_NATIVE_FUNCTION(InstantPrototype::to_string)
} }
// 8.3.12 Temporal.Instant.prototype.toLocaleString ( [ locales [ , options ] ] ), https://tc39.es/proposal-temporal/#sec-temporal.instant.prototype.tolocalestring // 8.3.12 Temporal.Instant.prototype.toLocaleString ( [ locales [ , options ] ] ), https://tc39.es/proposal-temporal/#sec-temporal.instant.prototype.tolocalestring
// NOTE: This is the minimum toLocaleString implementation for engines without ECMA-402. // 15.12.2.1 Temporal.Instant.prototype.toLocaleString ( [ locales [ , options ] ] ), https://tc39.es/proposal-temporal/#sup-temporal.instant.prototype.tolocalestring
JS_DEFINE_NATIVE_FUNCTION(InstantPrototype::to_locale_string) JS_DEFINE_NATIVE_FUNCTION(InstantPrototype::to_locale_string)
{ {
auto& realm = *vm.current_realm();
auto locales = vm.argument(0);
auto options = vm.argument(1);
// 1. Let instant be the this value. // 1. Let instant be the this value.
// 2. Perform ? RequireInternalSlot(instant, [[InitializedTemporalInstant]]). // 2. Perform ? RequireInternalSlot(instant, [[InitializedTemporalInstant]]).
auto instant = TRY(typed_this_object(vm)); auto instant = TRY(typed_this_object(vm));
// 3. Return TemporalInstantToString(instant, undefined, AUTO). // 3. Let dateFormat be ? CreateDateTimeFormat(%Intl.DateTimeFormat%, locales, options, ANY, ALL).
return PrimitiveString::create(vm, temporal_instant_to_string(instant, {}, Auto {})); auto date_format = TRY(Intl::create_date_time_format(vm, realm.intrinsics().intl_date_time_format_constructor(), locales, options, Intl::OptionRequired::Any, Intl::OptionDefaults::All));
// 4. Return ? FormatDateTime(dateFormat, instant).
return PrimitiveString::create(vm, TRY(Intl::format_date_time(vm, date_format, instant)));
} }
// 8.3.13 Temporal.Instant.prototype.toJSON ( ), https://tc39.es/proposal-temporal/#sec-temporal.instant.prototype.tojson // 8.3.13 Temporal.Instant.prototype.toJSON ( ), https://tc39.es/proposal-temporal/#sec-temporal.instant.prototype.tojson

2
Libraries/LibJS/Tests/builtins/Temporal/Instant/Instant.prototype.toLocaleString.js
View file

@ -5,7 +5,7 @@ describe("correct behavior", () => {
test("basic functionality", () => { test("basic functionality", () => {
const instant = new Temporal.Instant(1625614921123456789n); const instant = new Temporal.Instant(1625614921123456789n);
expect(instant.toLocaleString()).toBe("2021-07-06T23:42:01.123456789Z"); expect(instant.toLocaleString([], { timeZone: "UTC" })).toBe("7/6/2021, 11:42:01 PM");
}); });
}); });