mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-08 09:09:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibWeb: Remove range-count filter from selection change handlers

Browse source 
The implementation of setBaseAndExtent will create a new range.
This commit is contained in:
Timothy Flynn 2024-08-27 10:22:35 -04:00 • committed by Andreas Kling
commit 96ad310643
Notes: github-actions[bot] 2024-08-31 13:52:19 +00:00
2 changed files with 4 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Userland/Libraries/LibWeb/HTML/HTMLInputElement.cpp
View file

@ -2366,11 +2366,8 @@ void HTMLInputElement::selection_was_changed(size_t selection_start, size_t sele
{ {
document().set_cursor_position(DOM::Position::create(realm(), *m_text_node, selection_end)); document().set_cursor_position(DOM::Position::create(realm(), *m_text_node, selection_end));
auto selection = document().get_selection(); if (auto selection = document().get_selection())
if (!selection || selection->range_count() == 0) MUST(selection->set_base_and_extent(*m_text_node, selection_start, *m_text_node, selection_end));
return;
MUST(selection->set_base_and_extent(*m_text_node, selection_start, *m_text_node, selection_end));
} }
} }

7
Userland/Libraries/LibWeb/HTML/HTMLTextAreaElement.cpp
View file

@ -464,11 +464,8 @@ void HTMLTextAreaElement::selection_was_changed(size_t selection_start, size_t s
{ {
document().set_cursor_position(DOM::Position::create(realm(), *m_text_node, selection_end)); document().set_cursor_position(DOM::Position::create(realm(), *m_text_node, selection_end));
auto selection = document().get_selection(); if (auto selection = document().get_selection())
if (!selection || selection->range_count() == 0) MUST(selection->set_base_and_extent(*m_text_node, selection_start, *m_text_node, selection_end));
return;
MUST(selection->set_base_and_extent(*m_text_node, selection_start, *m_text_node, selection_end));
} }
} }