mirrors/ladybird
0
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2025-08-21 18:00:16 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 9

LibJS: Add minimum changes to build on Windows and run js.exe

Browse source 
This commit adds the minimal export macros needed to run js.exe on
windows. A followup commit is planned to move to explicit export
entirely.

A static_assert for the size of a struct is also ifdef'ed out as the
semantics around object layout and inheritance are different on MSVC abi
and the struct IteratorRecord ends up being 40 bytes not 32.
This commit is contained in:
R-Goc 2025-05-24 23:46:13 +02:00 • committed by Andrew Kaster
commit 96c197faf1
Notes: github-actions[bot] 2025-05-29 09:27:44 +00:00
6 changed files with 14 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Libraries/LibJS/Runtime/Iterator.h
View file

@ -37,7 +37,10 @@ private:
virtual void visit_edges(Cell::Visitor&) override;
};
// msvc abi semantics about layout with inheritance differ from Sys-V
#if !defined(AK_OS_WINDOWS)
static_assert(sizeof(IteratorRecord) == 32);
#endif
class Iterator : public Object {
JS_OBJECT(Iterator, Object);