From 96fbb33b13cb65a3a4ce721dd1531911b33db610 Mon Sep 17 00:00:00 2001
From: Timothy Flynn <trflynn89@pm.me>
Date: Wed, 25 Sep 2024 11:32:58 -0400
Subject: [PATCH] LibWeb: Log when document.execCommand and family are called

These are used by WPT. Log the commands so we know what we need to
implement.
---
 Userland/Libraries/LibWeb/DOM/Document.cpp | 18 ++++++++++++------
 Userland/Libraries/LibWeb/DOM/Document.h   | 12 ++++++------
 2 files changed, 18 insertions(+), 12 deletions(-)

diff --git a/Userland/Libraries/LibWeb/DOM/Document.cpp b/Userland/Libraries/LibWeb/DOM/Document.cpp
index cdbc25d902a..99295f0e58c 100644
--- a/Userland/Libraries/LibWeb/DOM/Document.cpp
+++ b/Userland/Libraries/LibWeb/DOM/Document.cpp
@@ -4959,38 +4959,44 @@ JS::Value Document::named_item_value(FlyString const& name) const
 }
 
 // https://w3c.github.io/editing/docs/execCommand/#execcommand()
-bool Document::exec_command(String, bool, String)
+bool Document::exec_command(String const& command, bool show_ui, String const& value)
 {
+    dbgln("FIXME: document.execCommand(\"{}\", {}, \"{}\")", command, show_ui, value);
     return false;
 }
 
 // https://w3c.github.io/editing/docs/execCommand/#querycommandenabled()
-bool Document::query_command_enabled(String)
+bool Document::query_command_enabled(String const& command)
 {
+    dbgln("FIXME: document.queryCommandEnabled(\"{}\")", command);
     return false;
 }
 
 // https://w3c.github.io/editing/docs/execCommand/#querycommandindeterm()
-bool Document::query_command_indeterm(String)
+bool Document::query_command_indeterm(String const& command)
 {
+    dbgln("FIXME: document.queryCommandIndeterm(\"{}\")", command);
     return false;
 }
 
 // https://w3c.github.io/editing/docs/execCommand/#querycommandstate()
-bool Document::query_command_state(String)
+bool Document::query_command_state(String const& command)
 {
+    dbgln("FIXME: document.queryCommandState(\"{}\")", command);
     return false;
 }
 
 // https://w3c.github.io/editing/docs/execCommand/#querycommandsupported()
-bool Document::query_command_supported(String)
+bool Document::query_command_supported(String const& command)
 {
+    dbgln("FIXME: document.queryCommandSupported(\"{}\")", command);
     return false;
 }
 
 // https://w3c.github.io/editing/docs/execCommand/#querycommandvalue()
-String Document::query_command_value(String)
+String Document::query_command_value(String const& command)
 {
+    dbgln("FIXME: document.queryCommandValue(\"{}\")", command);
     return String {};
 }
 
diff --git a/Userland/Libraries/LibWeb/DOM/Document.h b/Userland/Libraries/LibWeb/DOM/Document.h
index 86e8a469d5d..73968ad8455 100644
--- a/Userland/Libraries/LibWeb/DOM/Document.h
+++ b/Userland/Libraries/LibWeb/DOM/Document.h
@@ -561,12 +561,12 @@ public:
     void set_previous_document_unload_timing(DocumentUnloadTimingInfo const& previous_document_unload_timing) { m_previous_document_unload_timing = previous_document_unload_timing; }
 
     // https://w3c.github.io/editing/docs/execCommand/
-    bool exec_command(String command_id, bool show_ui, String value);
-    bool query_command_enabled(String command_id);
-    bool query_command_indeterm(String command_id);
-    bool query_command_state(String command_id);
-    bool query_command_supported(String command_id);
-    String query_command_value(String command_id);
+    bool exec_command(String const& command, bool show_ui, String const& value);
+    bool query_command_enabled(String const& command);
+    bool query_command_indeterm(String const& command);
+    bool query_command_state(String const& command);
+    bool query_command_supported(String const& command);
+    String query_command_value(String const& command);
 
     bool is_allowed_to_use_feature(PolicyControlledFeature) const;