mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2025-09-25 02:38:59 +00:00
LibWeb+Ladybird+Userland: Port window.[alert,confirm,prompt] to String
LibGUI and WebDriver (read: JSON) API boundaries use DeprecatedString, so that is as far as these changes can reach. The one change which isn't just a DeprecatedString to String replacement is handling the "null" prompt response. We previously checked for the null DeprecatedString, whereas we now represent this as an empty Optional<String>.
This commit is contained in:
parent
b4d3fea002
commit
97536e4684
Notes:
sideshowbarker
2024-07-17 08:37:36 +09:00
Author: https://github.com/trflynn89
Commit: 97536e4684
Pull-request: https://github.com/SerenityOS/serenity/pull/17841
Reviewed-by: https://github.com/gmta
Reviewed-by: https://github.com/linusg ✅
18 changed files with 85 additions and 85 deletions
|
@ -70,5 +70,5 @@ endpoint WebContentServer
|
|||
|
||||
alert_closed() =|
|
||||
confirm_closed(bool accepted) =|
|
||||
prompt_closed(DeprecatedString response) =|
|
||||
prompt_closed(Optional<String> response) =|
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue