From 97ad1ea7e009c570eb2f0570e16fc2a5b236eeb5 Mon Sep 17 00:00:00 2001 From: Sam Atkins Date: Wed, 25 Jun 2025 16:34:36 +0100 Subject: [PATCH] LibWeb/DOM: Don't crash getting custom properties from invalid pseudos --- Libraries/LibWeb/DOM/Element.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Libraries/LibWeb/DOM/Element.cpp b/Libraries/LibWeb/DOM/Element.cpp index 2ce5b5089fb..88b64cbd8ee 100644 --- a/Libraries/LibWeb/DOM/Element.cpp +++ b/Libraries/LibWeb/DOM/Element.cpp @@ -3026,10 +3026,13 @@ void Element::set_custom_properties(Optional pseudo_element, HashMap const& Element::custom_properties(Optional pseudo_element) const { + static HashMap s_empty_custom_properties; + if (!pseudo_element.has_value()) return m_custom_properties; - VERIFY(CSS::Selector::PseudoElementSelector::is_known_pseudo_element_type(pseudo_element.value())); + if (!CSS::Selector::PseudoElementSelector::is_known_pseudo_element_type(pseudo_element.value())) + return s_empty_custom_properties; return ensure_pseudo_element(pseudo_element.value()).custom_properties(); }